Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5706591068225536: Issue 2050 - Bubble popup shouldn`t be reusing the logo from the first-run page (Closed)

Created:
Feb. 26, 2015, 3:21 p.m. by Wladimir Palant
Modified:
Feb. 26, 2015, 7:12 p.m.
Visibility:
Public.

Description

Issue 2050 - Bubble popup shouldn`t be reusing the logo from the first-run page

Patch Set 1 #

Patch Set 2 : Using larger image for Retina displays #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
A icons/abp-64.png View Binary file 0 comments Download
M metadata.chrome View 1 chunk +1 line, -1 line 0 comments Download
M popup.html View 1 1 chunk +1 line, -1 line 0 comments Download
M skin/popup.css View 1 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6
Wladimir Palant
Feb. 26, 2015, 3:21 p.m. (2015-02-26 15:21:10 UTC) #1
Wladimir Palant
Changed reviewer - this should be reviewed by Thomas it seems.
Feb. 26, 2015, 3:23 p.m. (2015-02-26 15:23:36 UTC) #2
Sebastian Noack
(non module owner) LGTM
Feb. 26, 2015, 3:31 p.m. (2015-02-26 15:31:24 UTC) #3
Wladimir Palant
Changed this slightly to use a high-res image on Retina displays as suggested by Sebastian.
Feb. 26, 2015, 4:19 p.m. (2015-02-26 16:19:30 UTC) #4
Sebastian Noack
Awesome, LGTM.
Feb. 26, 2015, 4:20 p.m. (2015-02-26 16:20:43 UTC) #5
Thomas Greiner
Feb. 26, 2015, 6:59 p.m. (2015-02-26 18:59:37 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld