Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5715983079571456: Issue 309 - Don't use Shadow DOM in Chrome 32 (Closed)

Created:
April 17, 2014, 2:25 p.m. by Sebastian Noack
Modified:
April 22, 2014, 9:47 a.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Apparently there are some more builds between Chrome 32.0.1700 and 33 with broken <shadow> element.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed comments #

Total comments: 2

Patch Set 3 : Just check for Chrome 32 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include.preload.js View 1 2 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 7
Sebastian Noack
April 17, 2014, 2:28 p.m. (2014-04-17 14:28:30 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/5715983079571456/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5715983079571456/diff/5629499534213120/include.preload.js#newcode32 include.preload.js:32: if ("webkitCreateShadowRoot" in document.documentElement && !(/\bChrome\/32\.0\.(\d+)\b/.test(navigator.userAgent) && RegExp.$1 >= ...
April 17, 2014, 3:55 p.m. (2014-04-17 15:55:57 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5715983079571456/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5715983079571456/diff/5629499534213120/include.preload.js#newcode32 include.preload.js:32: if ("webkitCreateShadowRoot" in document.documentElement && !(/\bChrome\/32\.0\.(\d+)\b/.test(navigator.userAgent) && RegExp.$1 >= ...
April 17, 2014, 4:16 p.m. (2014-04-17 16:16:35 UTC) #3
Sebastian Noack
Apparently there also older builds of Chrome 32 (e.g. 32.0.1690) that are affected. It isn't ...
April 17, 2014, 4:48 p.m. (2014-04-17 16:48:42 UTC) #4
Thomas Greiner
LGTM with the nit addressed http://codereview.adblockplus.org/5715983079571456/diff/5724160613416960/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5715983079571456/diff/5724160613416960/include.preload.js#newcode33 include.preload.js:33: if ("webkitCreateShadowRoot" in document.documentElement ...
April 17, 2014, 5:39 p.m. (2014-04-17 17:39:00 UTC) #5
Sebastian Noack
http://codereview.adblockplus.org/5715983079571456/diff/5724160613416960/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5715983079571456/diff/5724160613416960/include.preload.js#newcode33 include.preload.js:33: if ("webkitCreateShadowRoot" in document.documentElement && !((match = navigator.userAgent.match(/\bChrome\/32\.0\.(\d+)\b/)) && ...
April 17, 2014, 5:56 p.m. (2014-04-17 17:56:45 UTC) #6
Thomas Greiner
April 22, 2014, 9:47 a.m. (2014-04-22 09:47:04 UTC) #7
LGTM

http://codereview.adblockplus.org/5715983079571456/diff/5717271485874176/incl...
File include.preload.js (right):

http://codereview.adblockplus.org/5715983079571456/diff/5717271485874176/incl...
include.preload.js:31: // the <shadow> element is broken in some Chrome 32
builts (#309)
Nit: Correct "builts" to "builds"

Powered by Google App Engine
This is Rietveld