Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: modules/trac/templates/site.erb

Issue 5719138018263040: Better way to set PATH_INFO variable for Trac (Closed)
Left Patch Set: Created March 11, 2014, 12:07 p.m.
Right Patch Set: Removed unnecessary assignment Created March 13, 2014, 6:50 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 server { 1 server {
2 server_name <%= @domain %>; 2 server_name <%= @domain %>;
3 3
4 <% if is_default %> 4 <% if is_default %>
5 listen 80 default_server; 5 listen 80 default_server;
6 listen [::]:80 default_server; 6 listen [::]:80 default_server;
7 <% else %> 7 <% else %>
8 listen 80; 8 listen 80;
9 listen [::]:80; 9 listen [::]:80;
10 <% end %> 10 <% end %>
(...skipping 15 matching lines...) Expand all
26 <% end %> 26 <% end %>
27 27
28 ssl_certificate adblockplus.org_sslcert.pem; 28 ssl_certificate adblockplus.org_sslcert.pem;
29 ssl_certificate_key adblockplus.org_sslcert.key; 29 ssl_certificate_key adblockplus.org_sslcert.key;
30 30
31 add_header Strict-Transport-Security max-age=31536000; 31 add_header Strict-Transport-Security max-age=31536000;
32 32
33 location / 33 location /
34 { 34 {
35 fastcgi_pass unix:/tmp/trac-fastcgi.sock; 35 fastcgi_pass unix:/tmp/trac-fastcgi.sock;
36 fastcgi_split_path_info ^()(.*)$; 36 fastcgi_split_path_info ^()(.*)$;
Felix Dahlke 2014/03/13 00:37:53 I assume you tested it, but based on the docs it s
Wladimir Palant 2014/03/13 06:50:41 Not sure where you've got it from, the docs quite
37 include /etc/nginx/fastcgi_params; 37 include /etc/nginx/fastcgi_params;
38 fastcgi_param SCRIPT_NAME "";
Felix Dahlke 2014/03/13 00:37:53 Is this still necessary? Seems to me as if fastcgi
Wladimir Palant 2014/03/13 06:50:41 You are right, this is unnecessary now.
39 fastcgi_param PATH_INFO $fastcgi_path_info; 38 fastcgi_param PATH_INFO $fastcgi_path_info;
40 } 39 }
41 40
42 location /chrome/ 41 location /chrome/
43 { 42 {
44 alias /home/trac/htdocs/htdocs/; 43 alias /home/trac/htdocs/htdocs/;
45 } 44 }
46 } 45 }
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld