chrome/ext/background.js - Issue 5721433737003008: Issue 1985 - Replaced __proto__ with Object.create() and Object.getPrototypeOf()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/ext/background.js

Issue 5721433737003008: Issue 1985 - Replaced __proto__ with Object.create() and Object.getPrototypeOf() (Closed)

Patch Set: Created Feb. 11, 2015, 11:51 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/ext/background.js

===================================================================

--- a/chrome/ext/background.js

+++ b/chrome/ext/background.js

@@ -319,7 +319,7 @@

/* Web requests */

- var framesOfTabs = {__proto__: null};

+ var framesOfTabs = Object.create(null);

ext.getFrame = function(tabId, frameId)

{

@@ -339,7 +339,7 @@

{

if (details && details.length > 0)

{

- var frames = framesOfTabs[tab.id] = {__proto__: null};

+ var frames = framesOfTabs[tab.id] = Object.create.(null);

for (var i = 0; i < details.length; i++)

frames[details[i].frameId] = {url: details[i].url, parent: null};

@@ -379,7 +379,7 @@

if (!isMainFrame)

frames = framesOfTabs[details.tabId];

if (!frames)

- frames = framesOfTabs[details.tabId] = {__proto__: null};

+ frames = framesOfTabs[details.tabId] = Object.create(null);

var frame = null;

if (!isMainFrame)

« no previous file with comments | « no previous file | chrome/ext/popup.js » ('j') | no next file with comments »