webrequest.js - Issue 5728050318671872: Issue 926 - Filters should not be applied on local pages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: webrequest.js

Issue 5728050318671872: Issue 926 - Filters should not be applied on local pages (Closed)

Patch Set: Created July 15, 2014, 12:04 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: webrequest.js

===================================================================

--- a/webrequest.js

+++ b/webrequest.js

@@ -49,7 +49,7 @@

function onBeforeRequest(url, type, page, frame)

{

- if (isFrameWhitelisted(page, frame))

+ if (!/^https?:/.test(url) || isFrameWhitelisted(page, frame))

Sebastian Noack 2014/07/15 22:47:44 Any reasons that you don't just change the url pat

Wladimir Palant 2014/07/16 07:12:29 Changing this in chrome/ext/background.js seems to

return true;

var docDomain = extractHostFromFrame(frame);

« no previous file with comments | « no previous file | no next file » | no next file with comments »