Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5731052198821888: #1203 - Establish nginx::hostconfig-fragment() directive (Closed)

Created:
Aug. 13, 2014, 9:07 a.m. by mathias
Modified:
Aug. 18, 2014, 11:42 a.m.
Reviewers:
Wladimir Palant
CC:
Felix Dahlke
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/1203#ticket

Patch Set 1 #

Patch Set 2 : #1203 - Migrate Trac setup to nginx::hostconfig-fragment #

Patch Set 3 : #1203 - Establish nginx::hostconfig-fragment() directive #

Total comments: 2

Patch Set 4 : #1203 - Establish nginx::hostconfig-fragment() directive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M modules/nginx/manifests/init.pp View 1 2 3 chunks +26 lines, -1 line 0 comments Download
M modules/nginx/templates/site.erb View 1 chunk +4 lines, -0 lines 0 comments Download
M modules/trac/manifests/init.pp View 1 2 3 3 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 7
mathias
Aug. 13, 2014, 9:07 a.m. (2014-08-13 09:07:29 UTC) #1
mathias
See https://issues.adblockplus.org/ticket/1203#ticket
Aug. 13, 2014, 9:24 a.m. (2014-08-13 09:24:01 UTC) #2
mathias
See https://issues.adblockplus.org/ticket/1203#ticket
Aug. 13, 2014, 9:49 a.m. (2014-08-13 09:49:53 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5731052198821888/diff/5639274879778816/modules/trac/manifests/init.pp File modules/trac/manifests/init.pp (right): http://codereview.adblockplus.org/5731052198821888/diff/5639274879778816/modules/trac/manifests/init.pp#newcode144 modules/trac/manifests/init.pp:144: nginx::hostconfig-fragment {"nginx_fragment_$name": No need to duplicate "nginx_fragment" in the ...
Aug. 14, 2014, 8:33 p.m. (2014-08-14 20:33:50 UTC) #4
mathias
See https://issues.adblockplus.org/ticket/1203#ticket
Aug. 18, 2014, 10:01 a.m. (2014-08-18 10:01:46 UTC) #5
mathias
http://codereview.adblockplus.org/5731052198821888/diff/5639274879778816/modules/trac/manifests/init.pp File modules/trac/manifests/init.pp (right): http://codereview.adblockplus.org/5731052198821888/diff/5639274879778816/modules/trac/manifests/init.pp#newcode144 modules/trac/manifests/init.pp:144: nginx::hostconfig-fragment {"nginx_fragment_$name": On 2014/08/14 20:33:50, Wladimir Palant wrote: > ...
Aug. 18, 2014, 10:03 a.m. (2014-08-18 10:03:26 UTC) #6
Wladimir Palant
Aug. 18, 2014, 11:42 a.m. (2014-08-18 11:42:21 UTC) #7
While the change itself looks fine, it doesn't seem that we want the additional
abstraction here. See https://issues.adblockplus.org/ticket/1203#comment:5 and
below.

Powered by Google App Engine
This is Rietveld