Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5738402414592000: Issue 1602 - Pass array directly from backupCustomFilters() to IO.writeToFile() (Closed)

Created:
April 2, 2015, 5 p.m. by Sebastian Noack
Modified:
April 16, 2015, 10:12 a.m.
Visibility:
Public.

Description

Since we are using for..of instead for..in inside IO.wirteToFile() now, we can pass arrays as well as generators, and don't need to wrap the former into the latter anymore.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/content/ui/filters-backup.js View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
April 2, 2015, 5:03 p.m. (2015-04-02 17:03:23 UTC) #1
Sebastian Noack
April 13, 2015, 10:37 a.m. (2015-04-13 10:37:16 UTC) #2
tschuster
April 14, 2015, 9:48 a.m. (2015-04-14 09:48:05 UTC) #3
On 2015/04/13 10:37:16, Sebastian Noack wrote:

LGTM

Powered by Google App Engine
This is Rietveld