Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5747446760079360: Issue 402 - Use a redirector script for downloads, not a direct link (Closed)

Created:
Sept. 9, 2014, 10:01 p.m. by Wladimir Palant
Modified:
Sept. 17, 2014, 7:21 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

This should run on the download server I think.

Patch Set 1 #

Patch Set 2 : Replaced time.clock() by time.time() #

Patch Set 3 : Fixed header encoding #

Total comments: 10

Patch Set 4 : #

Patch Set 5 : Got rid of polling #

Total comments: 4

Patch Set 6 : The threaded version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M multiplexer.fcgi View 1 chunk +4 lines, -0 lines 0 comments Download
M multiplexer.py View 1 chunk +9 lines, -2 lines 0 comments Download
A sitescripts/extensions/web/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A sitescripts/extensions/web/downloads.py View 1 2 3 4 5 1 chunk +61 lines, -0 lines 0 comments Download
M sitescripts/web.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14
Wladimir Palant
Sept. 9, 2014, 10:01 p.m. (2014-09-09 22:01:34 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5747446760079360/diff/5178081291534336/sitescripts/extensions/web/downloads.py File sitescripts/extensions/web/downloads.py (right): http://codereview.adblockplus.org/5747446760079360/diff/5178081291534336/sitescripts/extensions/web/downloads.py#newcode31 sitescripts/extensions/web/downloads.py:31: global links links doesn't have to be declared as ...
Sept. 15, 2014, 10:18 a.m. (2014-09-15 10:18:38 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/5747446760079360/diff/5178081291534336/sitescripts/extensions/web/downloads.py File sitescripts/extensions/web/downloads.py (right): http://codereview.adblockplus.org/5747446760079360/diff/5178081291534336/sitescripts/extensions/web/downloads.py#newcode32 sitescripts/extensions/web/downloads.py:32: update_links() On 2014/09/15 10:18:39, Sebastian Noack wrote: > Since ...
Sept. 15, 2014, 11:39 a.m. (2014-09-15 11:39:52 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/5747446760079360/diff/5178081291534336/sitescripts/extensions/web/downloads.py File sitescripts/extensions/web/downloads.py (right): http://codereview.adblockplus.org/5747446760079360/diff/5178081291534336/sitescripts/extensions/web/downloads.py#newcode32 sitescripts/extensions/web/downloads.py:32: update_links() On 2014/09/15 11:39:52, Wladimir Palant wrote: > On ...
Sept. 16, 2014, 9:33 a.m. (2014-09-16 09:33:39 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/5747446760079360/diff/5178081291534336/sitescripts/extensions/web/downloads.py File sitescripts/extensions/web/downloads.py (right): http://codereview.adblockplus.org/5747446760079360/diff/5178081291534336/sitescripts/extensions/web/downloads.py#newcode32 sitescripts/extensions/web/downloads.py:32: update_links() On 2014/09/16 09:33:40, Sebastian Noack wrote: > I ...
Sept. 16, 2014, 2:26 p.m. (2014-09-16 14:26:17 UTC) #5
Sebastian Noack
http://codereview.adblockplus.org/5747446760079360/diff/5178081291534336/sitescripts/extensions/web/downloads.py File sitescripts/extensions/web/downloads.py (right): http://codereview.adblockplus.org/5747446760079360/diff/5178081291534336/sitescripts/extensions/web/downloads.py#newcode32 sitescripts/extensions/web/downloads.py:32: update_links() On 2014/09/16 14:26:17, Wladimir Palant wrote: > On ...
Sept. 16, 2014, 2:30 p.m. (2014-09-16 14:30:04 UTC) #6
Wladimir Palant
On 2014/09/16 14:30:04, Sebastian Noack wrote: > Having that process run for as long as ...
Sept. 16, 2014, 3:04 p.m. (2014-09-16 15:04:47 UTC) #7
Wladimir Palant
I learned a lot more about multithreading in Python than I wanted but I think ...
Sept. 16, 2014, 7:15 p.m. (2014-09-16 19:15:21 UTC) #8
Sebastian Noack
http://codereview.adblockplus.org/5747446760079360/diff/5673385510043648/sitescripts/extensions/web/downloads.py File sitescripts/extensions/web/downloads.py (right): http://codereview.adblockplus.org/5747446760079360/diff/5673385510043648/sitescripts/extensions/web/downloads.py#newcode41 sitescripts/extensions/web/downloads.py:41: def update_links(): Since you are apparently fine with keeping ...
Sept. 17, 2014, 1:32 p.m. (2014-09-17 13:32:10 UTC) #9
Wladimir Palant
Argh, should have actually sent that comment... http://codereview.adblockplus.org/5747446760079360/diff/5673385510043648/sitescripts/extensions/web/downloads.py File sitescripts/extensions/web/downloads.py (right): http://codereview.adblockplus.org/5747446760079360/diff/5673385510043648/sitescripts/extensions/web/downloads.py#newcode41 sitescripts/extensions/web/downloads.py:41: def update_links(): ...
Sept. 17, 2014, 5:45 p.m. (2014-09-17 17:45:43 UTC) #10
Sebastian Noack
http://codereview.adblockplus.org/5747446760079360/diff/5673385510043648/sitescripts/extensions/web/downloads.py File sitescripts/extensions/web/downloads.py (right): http://codereview.adblockplus.org/5747446760079360/diff/5673385510043648/sitescripts/extensions/web/downloads.py#newcode41 sitescripts/extensions/web/downloads.py:41: def update_links(): On 2014/09/17 17:45:44, Wladimir Palant wrote: > ...
Sept. 17, 2014, 5:53 p.m. (2014-09-17 17:53:42 UTC) #11
Sebastian Noack
http://codereview.adblockplus.org/5747446760079360/diff/5673385510043648/sitescripts/extensions/web/downloads.py File sitescripts/extensions/web/downloads.py (right): http://codereview.adblockplus.org/5747446760079360/diff/5673385510043648/sitescripts/extensions/web/downloads.py#newcode41 sitescripts/extensions/web/downloads.py:41: def update_links(): On 2014/09/17 17:45:44, Wladimir Palant wrote: > ...
Sept. 17, 2014, 6:13 p.m. (2014-09-17 18:13:53 UTC) #12
Wladimir Palant
Ok, new version with more threading :)
Sept. 17, 2014, 7:04 p.m. (2014-09-17 19:04:24 UTC) #13
Sebastian Noack
Sept. 17, 2014, 7:06 p.m. (2014-09-17 19:06:44 UTC) #14
LGTM

Powered by Google App Engine
This is Rietveld