Issue #1234 - Rework strings in debug facility

src/plugin/Config.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 75 matching lines @@
 #if (defined ENABLE_DEBUG_INFO && defined ENABLE_DEBUG_ERROR)
 #define DEBUG_EXCEPTION(x) CPluginDebug::DebugException(x)
 #define DEBUG_ERROR_CODE(err, x) CPluginDebug::DebugErrorCode(err, x);
 #define DEBUG_ERROR_CODE_EX(err, x, process, thread) CPluginDebug::DebugErrorCode(err, x, process, thread);
 #else
 #define DEBUG_EXCEPTION(x)
 #define DEBUG_ERROR_CODE(err, x)
 #define DEBUG_ERROR_CODE_EX(err, x, process, thread)
 #endif
 
-#define DEBUG_ERROR_LOG(err, id, subid, description) CPluginClientBase::PostPluginError(err, id, subid, description);

[sergei, 2015/02/25 13:53:31]

Why is it changed from Log to Post?

[Eric, 2015/02/25 15:24:46]

The change is both a clarification and an optimization.

The optimization: The implementation of 'LogPluginError' has seven arguments,
the last three with default values. The fifth argument, 'isAsync', defaults to
false and controls flow within the function. This macro, not specifying the
value, uses the default. With the default value, the only behavior of
'LogPluginError' is to call 'PostPluginError'.

The clarification: In other words, use of this macro always uses the log queue.

[sergei, 2015/02/25 15:51:23]

Clear.
However, I would say that impl of `CPluginClientBase::LogPluginError` is
incorrect regarding `isAsync` because it should queue it if `isAsync` is true.
Anyway, it's not related to this issue, so it's OK.

[Eric, 2015/02/25 16:14:00]

Yes, I agree. The sense of 'isAsync' is backwards. 

In another pending review, these functions are part of the rump of
'CPluginClientBase' which is getting renamed to 'LogQueue'. That queue object
needs a rewrite, and we'll fix this naming issue then, likely by eliminating the
argument entirely with a new class structure with separate functions for
synchronous and asynchronous reporting.

+#define DEBUG_ERROR_LOG(err, id, subid, description) LogQueue::PostPluginError(err, id, subid, description);
 #define DEBUG_SYSTEM_EXCEPTION(ex, id, subid, description) CPluginDebug::DebugSystemException(ex, id, subid, description)
 #define DEBUG_SELFTEST(x)
 
 // ----------------------------------------------------------------------------
 // Miscellaneous
 // ----------------------------------------------------------------------------
 
 // Status bar pane name
 #define STATUSBAR_PANE_NAME L"AdblockPlusStatusBarPane"
 
 // Status bar pane number
 #define STATUSBAR_PANE_NUMBER 2
 
 #define ENGINE_STARTUP_TIMEOUT 10000
 
 
 
 #endif // _CONFIG_H