[IE] First round of ATL removal

src/plugin/PluginMutex.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginMutex.h"
 #include "PluginClient.h"
 #include "sddl.h"
 
 
 CPluginMutex::CPluginMutex(const std::wstring & name, int errorSubidBase) 
   : m_isLocked(false), m_errorSubidBase(errorSubidBase), mutex_name( L"Global\\AdblockPlus" + name )
 {
   if (m_errorSubidBase != PLUGIN_ERROR_MUTEX_DEBUG_FILE)
   {
     DEBUG_MUTEX( "Mutex::Create name:" + mutex_name )
   }
   m_hMutex = ::CreateMutexW( NULL, FALSE, mutex_name.c_str() );
   if (m_hMutex == NULL)
   {
     DWORD error = GetLastError();
     m_hMutex = OpenMutexW( MUTEX_ALL_ACCESS, FALSE, mutex_name.c_str() );
     if (m_hMutex == NULL)
     {
+      mutex_name = L"Local\\AdblockPlus" + name;
       m_hMutex = ::CreateMutexW( NULL, FALSE, mutex_name.c_str() );

[Oleksandr, 2014/06/26 00:48:43]

We should try to open a mutex in Local namespace if Global failed. It should not
be the same mutex_name here. Should be "Local\\Adblockplus" + name.

[Eric, 2014/06/26 15:13:56]

This a defect I introduced. I don't think I noticed that the string constants
were different.

Fixed in next patch set.

       if (m_hMutex == NULL)
       {
         m_hMutex = OpenMutexW( NULL, FALSE, mutex_name.c_str() );
         if (m_hMutex == NULL)
         {
           DWORD error = GetLastError();
           DEBUG_ERROR_LOG(::GetLastError(), PLUGIN_ERROR_MUTEX, PLUGIN_ERROR_MUTEX_CREATE + m_errorSubidBase, L"Mutex::CreateMutex");
         }
       }
       else
@@ skipping 59 matching lines @@
     }
   }
 
   m_hMutex = NULL;
 }
 
 bool CPluginMutex::IsLocked() const
 {
   return m_isLocked;
 }