Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/extensions/bin/createNightlies.py

Issue 5764619314397184: Issue 1048 - Generate devbuild update manifests for Android (Closed)
Patch Set: Created Sept. 19, 2014, 3:52 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sitescripts/extensions/bin/updateUpdateManifests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/extensions/bin/createNightlies.py
===================================================================
--- a/sitescripts/extensions/bin/createNightlies.py
+++ b/sitescripts/extensions/bin/createNightlies.py
@@ -31,7 +31,9 @@
from urllib import urlencode
from xml.dom.minidom import parse as parseXml
from sitescripts.utils import get_config, setupStderr, get_template
-from sitescripts.extensions.utils import compareVersions, Configuration, getSafariCertificateID
+from sitescripts.extensions.utils import (
+ compareVersions, Configuration, getSafariCertificateID,
+ writeAndroidUpdateManifest)
MAX_BUILDS = 50
@@ -200,6 +202,16 @@
elif self.config.type == 'android':
manifestPath = os.path.join(baseDir, "updates.xml")
templateName = 'androidUpdateManifest'
+
+ # ABP for Android used to have its own update manifest format. We need to
+ # generate both that and the new one in the libadblockplus format as long
+ # as a significant amount of users is on an old version.
+ newManifestPath = os.path.join(baseDir, "update.json")
+ writeAndroidUpdateManifest(newManifestPath, [{
+ 'basename': self.basename,
+ 'version': self.version,
+ 'updateURL': self.updateURL
+ }])
else:
manifestPath = os.path.join(baseDir, "update.rdf")
templateName = 'geckoUpdateManifest'
« no previous file with comments | « no previous file | sitescripts/extensions/bin/updateUpdateManifests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld