Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: notification.js

Issue 5767063142400000: notification fixes (Closed)
Left Patch Set: notification.html relocation, safari changes revert and notification.js update Created March 5, 2014, 3:10 p.m.
Right Patch Set: Nit fix for long lines Created March 6, 2014, 10:10 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « metadata.common ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17
18 //This case is true only for chrome when loading from notification.html
19 if (typeof ext === "undefined")
20 {
21 var ext = chrome.extension.getBackgroundPage().ext;
22 }
17 23
18 var backgroundPage = ext.backgroundPage.getWindow(); 24 var backgroundPage = ext.backgroundPage.getWindow();
19 var require = backgroundPage.require; 25 var require = backgroundPage.require;
20 26
21 var Utils = require("utils").Utils; 27 var Utils = require("utils").Utils;
22 var Notification = require("notification").Notification; 28 var Notification = require("notification").Notification;
23 29
24 function getDocLinks(notification) 30 function getDocLinks(notification)
25 { 31 {
26 if (!notification.links) 32 if (!notification.links)
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 84
79 messageElement.addEventListener("click", function(event) 85 messageElement.addEventListener("click", function(event)
80 { 86 {
81 var link = event.target; 87 var link = event.target;
82 while (link && link !== messageElement && link.localName !== "a") 88 while (link && link !== messageElement && link.localName !== "a")
83 link = link.parentNode; 89 link = link.parentNode;
84 if (!link) 90 if (!link)
85 return; 91 return;
86 event.preventDefault(); 92 event.preventDefault();
87 event.stopPropagation(); 93 event.stopPropagation();
88 backgroundPage.ext.windows.getLastFocused(function(win) { win.openTab(link.h ref); }); 94 ext.windows.getLastFocused(function(win) { win.openTab(link.href); });
89 }); 95 });
90 96
91 var notificationElement = document.getElementById("notification"); 97 var notificationElement = document.getElementById("notification");
92 notificationElement.className = notification.severity; 98 notificationElement.className = notification.severity;
93 notificationElement.style.display = "block"; 99 notificationElement.style.display = "block";
94 100
95 document.getElementById("close-notification").addEventListener("click", functi on() 101 document.getElementById("close-notification").addEventListener("click", functi on()
96 { 102 {
97 notificationElement.style.display = "none"; 103 notificationElement.style.display = "none";
98 }, false); 104 }, false);
99 }, false); 105 }, false);
LEFTRIGHT

Powered by Google App Engine
This is Rietveld