Fix named pipe security on Windows 7

src/shared/Utils.cpp

 #include <memory>
 #include <stdexcept>
 #include <vector>
 
 #include <Windows.h>
 #include <ShlObj.h>
 
 #include "Utils.h"
 
 namespace
 {
   // See http://blogs.msdn.com/b/oldnewthing/archive/2004/10/25/247180.aspx
   EXTERN_C IMAGE_DOS_HEADER __ImageBase;
 
   std::wstring appDataPath;
 
 }
 
 bool IsWindowsVistaOrLater()
 {
   OSVERSIONINFOEX osvi;
   ZeroMemory(&osvi, sizeof(OSVERSIONINFOEX));
   osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);
   GetVersionEx(reinterpret_cast<LPOSVERSIONINFO>(&osvi));
   return osvi.dwMajorVersion >= 6;
 }
 
-bool IsAppContainersSupported()
+bool IsWindows8OrLater()

[Eric, 2014/06/25 16:13:00]

How about combining the duplicated code to get the version number into a single
function that returns std::unique_ptr<OSVERSIONINFOEX>?

 {
-  //Try to allocate SID of AppContainer and see if it's succesful
-  PSID allAppContainersSid = 0;
-  SID_IDENTIFIER_AUTHORITY applicationAuthority = SECURITY_APP_PACKAGE_AUTHORITY;
-  BOOL res = AllocateAndInitializeSid(&applicationAuthority, 
-          SECURITY_BUILTIN_APP_PACKAGE_RID_COUNT,
-          SECURITY_APP_PACKAGE_BASE_RID,
-          SECURITY_BUILTIN_PACKAGE_ANY_PACKAGE,
-          0, 0, 0, 0, 0, 0,
-          &allAppContainersSid);
-
-  if (res == FALSE)
-  {
-    return false;
-  }
-  else
-  {
-    FreeSid(allAppContainersSid);
-    return true;
-  }
+  OSVERSIONINFOEX osvi;
+  ZeroMemory(&osvi, sizeof(OSVERSIONINFOEX));
+  osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);
+  GetVersionEx(reinterpret_cast<LPOSVERSIONINFO>(&osvi));
+  return osvi.dwMajorVersion >= 6 && osvi.dwMinorVersion >= 2;

[Wladimir Palant, 2014/05/15 07:36:18]

So if dwMajorVersion is 7 and dwMinorVersion is 0 then it is older than Windows
8?

 }
 
 std::string ToUtf8String(const std::wstring& str)
 {
   int length = static_cast<int>(str.size());
   if (length == 0)
     return std::string();
 
   int utf8StringLength = WideCharToMultiByte(CP_UTF8, 0, str.c_str(), length, 0, 0, 0, 0);
   if (utf8StringLength == 0)
@@ skipping 76 matching lines @@
 }
 
 void ReplaceString(std::wstring& input, const std::wstring placeholder, const std::wstring replacement)
 {
   size_t replaceStart = input.find(placeholder);
   if (replaceStart != std::string::npos)
   {
     input.replace(replaceStart, placeholder.length(), replacement);
   }
 }