Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include/AdblockPlus/FilterEngine.h

Issue 5797488346791936: Issue 1107 - Support notifications (Closed)
Left Patch Set: C++03 Created Jan. 23, 2015, 10:52 a.m.
Right Patch Set: fix comment Created Jan. 23, 2015, 3:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « include/AdblockPlus.h ('k') | include/AdblockPlus/Notification.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 233
234 /** 234 /**
235 * Retrieves all recommended subscriptions. 235 * Retrieves all recommended subscriptions.
236 * @return List of recommended subscriptions. 236 * @return List of recommended subscriptions.
237 */ 237 */
238 std::vector<SubscriptionPtr> FetchAvailableSubscriptions() const; 238 std::vector<SubscriptionPtr> FetchAvailableSubscriptions() const;
239 239
240 /** 240 /**
241 * Determines which notification is to be shown next. 241 * Determines which notification is to be shown next.
242 * @param url URL to match notifications to (optional). 242 * @param url URL to match notifications to (optional).
243 * @return Notification to be shown, or null if there is no any. 243 * @return Notification to be shown, or `null` if there is no any.
Felix Dahlke 2015/01/23 13:25:55 Can you add backticks around null? (`null`). That
244 */ 244 */
245 std::tr1::shared_ptr<Notification> GetNextNotificationToShow( 245 NotificationPtr GetNextNotificationToShow(
Felix Dahlke 2015/01/23 13:25:55 Why not use NotificationPtr here?
246 const std::string& url = std::string()); 246 const std::string& url = std::string());
247 247
248 /** 248 /**
249 * Checks if any active filter matches the supplied URL. 249 * Checks if any active filter matches the supplied URL.
250 * @param url URL to match. 250 * @param url URL to match.
251 * @param contentType Content type of the requested resource. 251 * @param contentType Content type of the requested resource.
252 * @param documentUrl URL of the document requesting the resource. 252 * @param documentUrl URL of the document requesting the resource.
253 * Note that there will be more than one document if frames are 253 * Note that there will be more than one document if frames are
254 * involved, see 254 * involved, see
255 * Matches(const std::string&, const std::string&, const std::vector< std::string>&) const. 255 * Matches(const std::string&, const std::string&, const std::vector< std::string>&) const.
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 ContentType contentType, 383 ContentType contentType,
384 const std::string& documentUrl) const; 384 const std::string& documentUrl) const;
385 void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params); 385 void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params);
386 void UpdateCheckDone(const std::string& eventName, 386 void UpdateCheckDone(const std::string& eventName,
387 UpdateCheckDoneCallback callback, JsValueList& params); 387 UpdateCheckDoneCallback callback, JsValueList& params);
388 void FilterChanged(FilterChangeCallback callback, JsValueList& params); 388 void FilterChanged(FilterChangeCallback callback, JsValueList& params);
389 }; 389 };
390 } 390 }
391 391
392 #endif 392 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld