Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/prefs.js

Issue 5797488346791936: Issue 1107 - Support notifications (Closed)
Left Patch Set: C++03 Created Jan. 23, 2015, 10:52 a.m.
Right Patch Set: fix comment Created Jan. 23, 2015, 3:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/api.js ('k') | libadblockplus.gyp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 22 matching lines...) Expand all
33 subscriptions_autoupdate: true, 33 subscriptions_autoupdate: true,
34 subscriptions_exceptionsurl: "https://easylist-downloads.adblockplus.org/excep tionrules.txt", 34 subscriptions_exceptionsurl: "https://easylist-downloads.adblockplus.org/excep tionrules.txt",
35 documentation_link: "https://adblockplus.org/redirect?link=%LINK%&lang=%LANG%" , 35 documentation_link: "https://adblockplus.org/redirect?link=%LINK%&lang=%LANG%" ,
36 update_url_release: "https://update.adblockplus.org/%NAME%/update.json?type=%T YPE%", 36 update_url_release: "https://update.adblockplus.org/%NAME%/update.json?type=%T YPE%",
37 update_url_devbuild: "https://adblockplus.org/devbuilds/%NAME%/update.json?typ e=%TYPE%", 37 update_url_devbuild: "https://adblockplus.org/devbuilds/%NAME%/update.json?typ e=%TYPE%",
38 update_last_check: 0, 38 update_last_check: 0,
39 update_last_error: 0, 39 update_last_error: 0,
40 update_soft_expiration: 0, 40 update_soft_expiration: 0,
41 update_hard_expiration: 0, 41 update_hard_expiration: 0,
42 currentVersion: "0.0", 42 currentVersion: "0.0",
43 notificationdata: { 43 notificationdata: {},
44 shown: [],
Felix Dahlke 2015/01/23 13:25:55 Wouldn't it work all the same if we initialised no
sergei 2015/01/23 14:48:19 May be some previous test covered the case when it
45 },
46 notificationurl: "https://notification.adblockplus.org/notification.json" 44 notificationurl: "https://notification.adblockplus.org/notification.json"
47 }; 45 };
48 46
49 let values = Object.create(defaults); 47 let values = Object.create(defaults);
50 let path = _fileSystem.resolve("prefs.json"); 48 let path = _fileSystem.resolve("prefs.json");
51 let listeners = []; 49 let listeners = [];
52 let isDirty = false; 50 let isDirty = false;
53 let isSaving = false; 51 let isSaving = false;
54 52
55 function defineProperty(key) 53 function defineProperty(key)
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 let index = listeners.indexOf(listener); 124 let index = listeners.indexOf(listener);
127 if (index >= 0) 125 if (index >= 0)
128 listeners.splice(index, 1); 126 listeners.splice(index, 1);
129 }, 127 },
130 }; 128 };
131 129
132 for (let key in defaults) 130 for (let key in defaults)
133 defineProperty(key); 131 defineProperty(key);
134 132
135 load(); 133 load();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld