Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/FilterEngine.h

Issue 5797488346791936: Issue 1107 - Support notifications (Closed)
Patch Set: move MarkAsShown into Notification class and get rid of locale arg in Notification::GetTexts Created Jan. 22, 2015, 10:02 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/AdblockPlus/FilterEngine.h
diff --git a/include/AdblockPlus/FilterEngine.h b/include/AdblockPlus/FilterEngine.h
index b81433f5c9bf1b540cf837f6df1a1662bc623454..b7dd29e3272439338958f945bba59ec5790e9478 100644
--- a/include/AdblockPlus/FilterEngine.h
+++ b/include/AdblockPlus/FilterEngine.h
@@ -24,6 +24,7 @@
#include <vector>
#include <AdblockPlus/JsEngine.h>
#include <AdblockPlus/JsValue.h>
+#include <AdblockPlus/Notification.h>
#include "tr1_memory.h"
@@ -237,6 +238,35 @@ namespace AdblockPlus
std::vector<SubscriptionPtr> FetchAvailableSubscriptions() const;
/**
+ * Creates new Notification(see `Notification`) object.
+ * @param type Type of the notification.
+ * @param id Id of the newly created notification.
+ * @return New Notification instance.
+ */
+ std::tr1::shared_ptr<Notification> CreateNotification(NotificationType type,
+ const std::string& id) const;
Wladimir Palant 2015/01/22 10:47:20 This method still needs to be removed, along with
+
+ /**
+ * Determines which notification is to be shown next.
+ * @param url URL to match notifications to (optional).
+ * @return Notification to be shown, or null if there is no any.
+ */
+ std::tr1::shared_ptr<Notification> GetNextNotificationToShow(
+ const std::string& url = std::string());
+
+ /**
+ * Adds a local notification.
+ * @param value The notification to add
+ */
+ void AddNotification(const std::tr1::shared_ptr<Notification>& value);
+
+ /**
+ * Removes an existing local notification.
+ * @param notification The notification to remove.
+ */
+ void RemoveNotification(const std::tr1::shared_ptr<Notification>& value);
+
+ /**
* Checks if any active filter matches the supplied URL.
* @param url URL to match.
* @param contentType Content type of the requested resource.

Powered by Google App Engine
This is Rietveld