ext/background.js - Issue 5817039037923328: Issue 1813 - Implement ext.showOptions() in Firefox

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: ext/background.js

Issue 5817039037923328: Issue 1813 - Implement ext.showOptions() in Firefox (Closed)

Left Patch Set: Created Jan. 15, 2015, 1:02 p.m.

Right Patch Set: Removed callback parameter Created Jan. 15, 2015, 2:47 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2015 Eyeo GmbH	3 * Copyright (C) 2006-2015 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 78 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
89 return this._map.has(page._sender);	89 return this._map.has(page._sender);

90 },	90 },

91	91

92 delete: function(page)	92 delete: function(page)

93 {	93 {

94 this._map.delete(page._sender);	94 this._map.delete(page._sender);

95 }	95 }

96 };	96 };

97 exports.PageMap = PageMap;	97 exports.PageMap = PageMap;

98	98

99 exports.showOptions = function(callback)	99 exports.showOptions = function()

100 {	100 {

101 if (typeof callback != "undefined")

102 Cu.reportError("Unsupported callback parameter passed to ext.showOptions");
Sebastian Noack 2015/01/15 13:04:57 Just omit the callback argument? The rest of the a Just omit the callback argument? The rest of the application layer usually doesn't check for unsupported features, used on other platforms. Wladimir Palant 2015/01/15 14:47:34 It was meant mostly as a reminder, this will likel Show quoted text On 2015/01/15 13:04:57, Sebastian Noack wrote: > Just omit the callback argument? The rest of the application layer usually > doesn't check for unsupported features, used on other platforms. It was meant mostly as a reminder, this will likely be unified in future. But - fine with me.
103

104 require("ui").UI.openFiltersDialog();	101 require("ui").UI.openFiltersDialog();

105 };	102 };

LEFT	RIGHT