Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5842912759775232: Issue 2509 - Add Adblock Browser to known apps (Closed)

Created:
May 12, 2015, 8:28 p.m. by Felix Dahlke
Modified:
May 22, 2015, 12:57 p.m.
Visibility:
Public.

Description

Issue 2509 - Add Adblock Browser to known apps

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M packagerGecko.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
Felix Dahlke
May 12, 2015, 8:29 p.m. (2015-05-12 20:29:49 UTC) #1
Sebastian Noack
LGTM
May 13, 2015, 5:53 a.m. (2015-05-13 05:53:43 UTC) #2
Wladimir Palant
This change shouldn't be necessary - you are already replacing getMetadata() function from build.py, you ...
May 15, 2015, 7:19 p.m. (2015-05-15 19:19:45 UTC) #3
Wladimir Palant
May 15, 2015, 7:29 p.m. (2015-05-15 19:29:43 UTC) #4
Never mind, didn't realize that this is the final fix rather than the quick and
dirty solution.

LGTM

Powered by Google App Engine
This is Rietveld