Disable the start pane

mobile/android/base/BrowserApp.java

 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*-
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 package org.mozilla.gecko;
 
 import java.io.File;
 import java.io.FileNotFoundException;
 import java.lang.reflect.Method;
@@ skipping 604 matching lines @@
     }
 
     /**
      * Check and show Onboarding start pane if Firefox has never been launched and
      * is not opening an external link from another application.
      *
      * @param context Context of application; used to show Start Pane if appropriate
      * @param intentAction Intent that launched this activity
      */
     private void checkStartPane(Context context, String intentAction) {
+        // We never want the start pane to show up in Adblock Browser.

[Felix Dahlke, 2015/03/01 12:00:50]

There are two places where we can keep the start pane from showing up - here
(where it's shown) and in GeckoProfile.java, where PREF_STARTPANE_ENABLED is
initialised.

I've opted for making the cut here, since it'll keep the pane from showing up no
matter what, and since I don't need to touch existing code here.

[René Jeschke, 2015/03/01 18:27:30]

I really don't like having dead code lying around, but if you really want to fix
it this way, we should file a follow-up issue to check if we can disable this by
modifying GeckoProfile only.
If so, modifying a single line instead of adding four might also be a 'minimal'
change.

[Felix Dahlke, 2015/03/02 03:46:59]

We can change it in GeckoProfile, as I said. But the change is more messy, we
need to modify existing code rather than add some new code above it, as we can
here.

We need to change this:

// Initialize pref flag for displaying the start pane for a new non-webapp
profile.
if (!mIsWebAppProfile) {
    final SharedPreferences prefs =
GeckoSharedPrefs.forProfile(mApplicationContext);
    prefs.edit().putBoolean(BrowserApp.PREF_STARTPANE_ENABLED, true).apply();
}

Into something like this:

// Initialize pref flag for displaying the start pane for a new non-webapp
profile.
// In Adblock Browser, however, we never want to see the start pane.
if (false && !mIsWebAppProfile) {
    final SharedPreferences prefs =
GeckoSharedPrefs.forProfile(mApplicationContext);
    prefs.edit().putBoolean(BrowserApp.PREF_STARTPANE_ENABLED, true).apply();
}

That's arguably more messy. Sure, we could also just remove the code,
effectively never setting startpane to enabled. But that's also a more intrusive
change.

+        if (true)
+            return;
+
         final StrictMode.ThreadPolicy savedPolicy = StrictMode.allowThreadDiskReads();
 
         try {
             final SharedPreferences prefs = GeckoSharedPrefs.forProfile(this);
 
             if (prefs.getBoolean(PREF_STARTPANE_ENABLED, false)) {
                 if (!Intent.ACTION_VIEW.equals(intentAction)) {
                     final DialogFragment dialog = new StartPane();
                     dialog.show(getSupportFragmentManager(), ONBOARD_STARTPANE_TAG);
                 }
@@ skipping 2529 matching lines @@
                                                   final SessionInformation previousSession) {
         return new BrowserHealthRecorder(context,
                                          GeckoSharedPrefs.forApp(context),
                                          profilePath,
                                          dispatcher,
                                          osLocale,
                                          appLocale,
                                          previousSession);
     }
 }