Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5933140862304256: Issue 1655 - Add "short_name" to manifest.json for Chrome and Opera (Closed)

Created:
Dec. 3, 2014, 3:35 p.m. by Sebastian Noack
Modified:
Dec. 3, 2014, 4:45 p.m.
Reviewers:
Thomas Greiner
CC:
Wladimir Palant, kzar
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M manifest.json.tmpl View 1 chunk +1 line, -0 lines 3 comments Download

Messages

Total messages: 4
Sebastian Noack
Dec. 3, 2014, 3:37 p.m. (2014-12-03 15:37:28 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/5933140862304256/diff/5629499534213120/manifest.json.tmpl File manifest.json.tmpl (right): http://codereview.adblockplus.org/5933140862304256/diff/5629499534213120/manifest.json.tmpl#newcode13 manifest.json.tmpl:13: "short_name": "__MSG_name__", Since this field is limited to 12 ...
Dec. 3, 2014, 3:47 p.m. (2014-12-03 15:47:21 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5933140862304256/diff/5629499534213120/manifest.json.tmpl File manifest.json.tmpl (right): http://codereview.adblockplus.org/5933140862304256/diff/5629499534213120/manifest.json.tmpl#newcode13 manifest.json.tmpl:13: "short_name": "__MSG_name__", On 2014/12/03 15:47:22, Thomas Greiner wrote: > ...
Dec. 3, 2014, 3:57 p.m. (2014-12-03 15:57:44 UTC) #3
Thomas Greiner
Dec. 3, 2014, 4:19 p.m. (2014-12-03 16:19:38 UTC) #4
Please note that according to
https://code.google.com/p/chromium/issues/detail?id=317165 "short_name" has only
been supported since Chrome 31 but it doesn't appear to cause any problems
whatsoever in older versions.

Therefore LGTM

http://codereview.adblockplus.org/5933140862304256/diff/5629499534213120/mani...
File manifest.json.tmpl (right):

http://codereview.adblockplus.org/5933140862304256/diff/5629499534213120/mani...
manifest.json.tmpl:13: "short_name": "__MSG_name__",
On 2014/12/03 15:57:44, Sebastian Noack wrote:
> Also note that it is truncated in
> packagerChrome.py anyway in case it has more than 12 chars.

Ok, that's fine then.

Powered by Google App Engine
This is Rietveld