Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5943816674607104: Issue 1983 - Dispatch onLoading event for prerendered pages (Closed)

Created:
Feb. 10, 2015, 12:23 p.m. by Sebastian Noack
Modified:
Feb. 10, 2015, 5:40 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Don't remove entry from framesOfTab #

Patch Set 3 : Consider that Chrome resets browser actions on navigation #

Patch Set 4 : Simplified changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M chrome/ext/background.js View 1 2 3 1 chunk +27 lines, -6 lines 0 comments Download

Messages

Total messages: 8
Sebastian Noack
Feb. 10, 2015, 12:24 p.m. (2015-02-10 12:24:03 UTC) #1
Sebastian Noack
It turned out that we can't deallocate the frame hierarchy on navigation, which was causing ...
Feb. 10, 2015, 12:47 p.m. (2015-02-10 12:47:53 UTC) #2
kzar
LGTM
Feb. 10, 2015, 3:42 p.m. (2015-02-10 15:42:25 UTC) #3
Sebastian Noack
Now it is getting complicated. I realized that Chrome is automatically resetting the browser action ...
Feb. 10, 2015, 5:01 p.m. (2015-02-10 17:01:33 UTC) #4
Wladimir Palant
LGTM Quite a hack, but given https://code.google.com/p/chromium/issues/detail?id=93646 this seems to be the best we can ...
Feb. 10, 2015, 5:32 p.m. (2015-02-10 17:32:35 UTC) #5
kzar
LGTM (I found the last patchset much easier to understand, with the simplified changes and ...
Feb. 10, 2015, 5:37 p.m. (2015-02-10 17:37:20 UTC) #6
Sebastian Noack
On 2015/02/10 17:32:35, Wladimir Palant wrote: > LGTM > > Quite a hack, but given ...
Feb. 10, 2015, 5:37 p.m. (2015-02-10 17:37:25 UTC) #7
Sebastian Noack
Feb. 10, 2015, 5:37 p.m. (2015-02-10 17:37:25 UTC) #8
On 2015/02/10 17:32:35, Wladimir Palant wrote:
> LGTM
> 
> Quite a hack, but given
> https://code.google.com/p/chromium/issues/detail?id=93646 this seems to be the
> best we can do.

Yeah, I've reported a related issue quite some time ago:
https://code.google.com/p/chromium/issues/detail?id=418193

And finally found a way to workaround Chrome's silly pre-rendered tabs issue.
Also see: http://codereview.adblockplus.org/6089170179063808

Powered by Google App Engine
This is Rietveld