Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5958799332474880: Issue 2101 - Avoid duplicate interface page strings. (Closed)

Created:
March 8, 2015, 3:14 p.m. by kzar
Modified:
March 9, 2015, 12:51 p.m.
Visibility:
Public.

Description

Issue 2101 - Avoid duplicate interface page strings.

Patch Set 1 #

Patch Set 2 : Moved the other interface strings into locale file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M includes/interface.tmpl View 1 3 chunks +5 lines, -5 lines 0 comments Download
M locales/en/IAdblockPlus.json View 1 chunk +0 lines, -6 lines 0 comments Download
M locales/en/IAdblockPlusSubscription.json View 1 chunk +0 lines, -6 lines 0 comments Download
A locales/en/interface.json View 1 1 chunk +20 lines, -0 lines 0 comments Download
M pages/IAdblockPlus.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/IAdblockPlusSubscription.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
kzar
March 8, 2015, 3:16 p.m. (2015-03-08 15:16:20 UTC) #1
Wladimir Palant
Again, automatically converted content should be modified by means of changing the conversion script, not ...
March 8, 2015, 7:15 p.m. (2015-03-08 19:15:28 UTC) #2
kzar
Apart from the change to interface.tmpl these changes are all generated by the conversion script. ...
March 8, 2015, 7:27 p.m. (2015-03-08 19:27:25 UTC) #3
Wladimir Palant
There are more strings that should be in interface.json, I added them in https://github.com/kzar/adblockplus-website-converter/commit/13e93b7b54e1537672bdc78c15047c3d92f273ef. Could ...
March 8, 2015, 10:33 p.m. (2015-03-08 22:33:39 UTC) #4
kzar
Patch Set 2 : Moved the other interface strings into locale file. Thanks, sorry I ...
March 8, 2015, 11:27 p.m. (2015-03-08 23:27:01 UTC) #5
Wladimir Palant
March 9, 2015, 10:05 a.m. (2015-03-09 10:05:13 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld