Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5964611362750464: Issue 2233 - Adapted array type annotations for JsDoc 3 (Closed)

Created:
March 30, 2015, 4:51 p.m. by Sebastian Noack
Modified:
April 1, 2015, 8:44 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2233 - Adapted array type annotations for JsDoc 3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re-added removed argument name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M lib/filterClasses.js View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/filterNotifier.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/objectTabs.js View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/subscriptionClasses.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M lib/utils.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Sebastian Noack
March 30, 2015, 4:52 p.m. (2015-03-30 16:52:37 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5964611362750464/diff/5629499534213120/lib/subscriptionClasses.js File lib/subscriptionClasses.js (right): http://codereview.adblockplus.org/5964611362750464/diff/5629499534213120/lib/subscriptionClasses.js#newcode126 lib/subscriptionClasses.js:126: * @param {string[]} buffer to push the serialization results ...
March 30, 2015, 6:58 p.m. (2015-03-30 18:58:05 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5964611362750464/diff/5629499534213120/lib/subscriptionClasses.js File lib/subscriptionClasses.js (right): http://codereview.adblockplus.org/5964611362750464/diff/5629499534213120/lib/subscriptionClasses.js#newcode126 lib/subscriptionClasses.js:126: * @param {string[]} buffer to push the serialization results ...
March 30, 2015, 10:51 p.m. (2015-03-30 22:51:54 UTC) #3
Wladimir Palant
March 31, 2015, 1:30 p.m. (2015-03-31 13:30:04 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld