Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/plugin/UserSettingsTest.cpp

Issue 5979857238360064: Issues #1163, #1173 - refactor CPluginUserSettings (Closed)
Patch Set: nit fixes Created Feb. 13, 2015, 2:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/plugin/PluginUserSettings.cpp ('K') | « src/plugin/PluginUserSettings.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/plugin/UserSettingsTest.cpp
===================================================================
--- a/test/plugin/UserSettingsTest.cpp
+++ b/test/plugin/UserSettingsTest.cpp
@@ -14,7 +14,6 @@
* You should have received a copy of the GNU General Public License
* along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
*/
-
#include <gtest/gtest.h>
#include <OAIdl.h>
@@ -44,11 +43,6 @@
DISPID ids[1];
HRESULT h = x.GetIDsOfNames(IID_NULL, names, 1, 0, ids);
ASSERT_NE(S_OK, h);
- // The old version returns a nonstandard error code.
- if (h == DISP_E_MEMBERNOTFOUND)
- {
- return;
- }
EXPECT_EQ(DISP_E_UNKNOWNNAME, h);
}
}
@@ -69,6 +63,7 @@
SingleMethodNameFound(L"GetDocumentationLink", 10);
SingleMethodNameFound(L"IsAcceptableAdsEnabled", 11);
SingleMethodNameFound(L"SetAcceptableAdsEnabled", 12);
+ SingleMethodNameFound(L"IsUpdate", 13);
}
TEST(CPluginUserSettingsGetIDsOfNames, UndefinedMethodsMustNotBeFound)
@@ -95,11 +90,6 @@
EXCEPINFO ex;
HRESULT h = x.Invoke(id, IID_NULL, 0, DISPATCH_METHOD, &params, nullptr, &ex, nullptr);
ASSERT_NE(S_OK, h);
- // The old version returns a nonstandard error code.
- if (h == DISP_E_BADINDEX)
- {
- return;
- }
EXPECT_EQ(DISP_E_MEMBERNOTFOUND, h);
}
}
« src/plugin/PluginUserSettings.cpp ('K') | « src/plugin/PluginUserSettings.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld