Issue 1820 - Fixed issue where multiple tabs were highlghited

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 30 matching lines @@
       var frames = framesOfTabs[this._id];
       if (frames)
       {
         var frame = frames[0];
         if (frame)
           return frame.url;
       }
     },
     activate: function()
     {
-      chrome.tabs.update(this._id, {highlighted: true});
+      chrome.tabs.get(this._id, function(tab)
+      {
+        chrome.tabs.highlight(
+          {
+            windowId: tab.windowId,
+            tabs: [tab.index]

[Wladimir Palant, 2015/01/16 15:59:17]

I wonder why they created an API that works with tab indices when everything
else expects tab IDs. Let's hope nobody ever runs into a race condition here.

+          },
+          function() {}
+        );
+      });
     },
     sendMessage: function(message, responseCallback)
     {
       chrome.tabs.sendMessage(this._id, message, responseCallback);
     }
   };
 
   ext._getPage = function(id)
   {
     return new Page({id: parseInt(id, 10)});
@@ skipping 354 matching lines @@
       if (!win.incognito)
         queryInfo.windowId = win.id;
 
       chrome.tabs.query(queryInfo, function(tabs)
       {
         if (tabs.length > 0)
         {
           var tab = tabs[0];
 
           chrome.windows.update(tab.windowId, {focused: true});
-          chrome.tabs.update(tab.id, {highlighted: true});
+          chrome.tabs.highlight(
+            {
+              windowId: tab.windowId,
+              tabs: [tab.index]
+            },
+            function() {}
+          );
 
           if (callback)
             callback(new Page(tab));
         }
         else
         {
           ext.pages.open(optionsUrl, callback);
         }
       });
     });
   };
 })();