Issue 662 - Job links shouldn't use anchors

filters/find.py

-def find(sequence, value, attribute=None):
+from jinja2 import environmentfilter
+
+@environmentfilter
+def find(environment, sequence, value, attribute=None):
   for item in sequence:
-    if ((attribute is None and item == value) or
-        (attribute is not None and item[attribute] == value)):

[Sebastian Noack, 2015/03/20 17:50:28]

If you insist on keeping this weird filter, can we please simplify the logic at
least?

(item if attribute is None else item[attribute]) == value

[Wladimir Palant, 2015/03/20 18:22:40]

Not that much simpler but fine with me.

[Sebastian Noack, 2015/03/21 12:34:44]

Moreover, you should use environment.getitem(). Otherwise only items, but no
attributes will be considered.

@environmentfilter
def find(environment, sequence, value, attr=None)
  for item in sequence:
    if (item if attr is None else environment.getitem(item, attr)) == value:
      return item
  return None

[saroyanm, 2015/03/21 17:27:10]

Done.

[Wladimir Palant, 2015/03/22 22:06:42]

I doubt that this is a good idea. Environment.getitem() isn't documented - it's
an internal utility function that we shouldn't rely on unless we want to risk
breakage with a future Jinja2 version. Not sure whether duplicating getattr()
from Jinja2 is worth it but at least it would be a reliable solution without a
bogus dependency on the Jinja2 environment:

  def getattribute(obj, attribute):
    try:
      return getattr(obj, attribute)
    except AttributeError:
      return obj[attribute]

[saroyanm, 2015/03/22 23:40:51]

Done.

+    if (item if attribute is None else environment.getitem(item, attribute)) == value:
       return item
   return None