Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/plugin/PluginClientBase.h

Issue 6012307226230784: Issue #1234 - std::wstring version of UnescapeUrl (Closed)
Left Patch Set: Created Aug. 1, 2014, 1:49 p.m.
Right Patch Set: Created Oct. 1, 2014, 6:52 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | src/plugin/PluginClientBase.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #ifndef _PLUGIN_CLIENT_BASE_H_ 1 #ifndef _PLUGIN_CLIENT_BASE_H_
2 #define _PLUGIN_CLIENT_BASE_H_ 2 #define _PLUGIN_CLIENT_BASE_H_
3 3
4 4
5 #include "PluginTypedef.h" 5 #include "PluginTypedef.h"
6 6
7 7
8 class CPluginClientFactory; 8 class CPluginClientFactory;
9 9
10 10
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 CPluginClientBase(); 60 CPluginClientBase();
61 61
62 static CComAutoCriticalSection s_criticalSectionLocal; 62 static CComAutoCriticalSection s_criticalSectionLocal;
63 63
64 public: 64 public:
65 65
66 ~CPluginClientBase(); 66 ~CPluginClientBase();
67 67
68 static void SetLocalization(); 68 static void SetLocalization();
69 69
70 static bool IsValidDomain(const CString& domain);
71 static CString& UnescapeUrl(CString& url); 70 static CString& UnescapeUrl(CString& url);
72 71
73 static void LogPluginError(DWORD errorCode, int errorId, int errorSubid, const CString& description="", bool isAsync=false, DWORD dwProcessId=0, DWORD dwThrea dId=0); 72 static void LogPluginError(DWORD errorCode, int errorId, int errorSubid, const CString& description="", bool isAsync=false, DWORD dwProcessId=0, DWORD dwThrea dId=0);
74 73
75 static void PostPluginError(int errorId, int errorSubid, DWORD errorCode, cons t CString& errorDescription); 74 static void PostPluginError(int errorId, int errorSubid, DWORD errorCode, cons t CString& errorDescription);
76 static bool PopFirstPluginError(CPluginError& pluginError); 75 static bool PopFirstPluginError(CPluginError& pluginError);
77 }; 76 };
78 77
79 /** 78 /**
80 * Wrapper around Microsoft API 'UrlUnescape' 79 * Wrapper around Microsoft API 'UrlUnescape'
81 * 80 *
82 * This function has modify-in-place semantics; it's a legacy. 81 * This function has modify-in-place semantics.
82 * This behavior matches that of the legacy version of this function declared ab ove.
83 * At present, callers of this function have no code to handle error conditions that might arise here.
84 * Because there's no error handling, therefore, this masks failures in UrlUnesc ape.
83 */ 85 */
84 void UnescapeUrl(std::wstring& url); 86 void UnescapeUrl(std::wstring& url);
85 87
86 #endif // _PLUGIN_CLIENT_BASE_H_ 88 #endif // _PLUGIN_CLIENT_BASE_H_
LEFTRIGHT

Powered by Google App Engine
This is Rietveld