Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginClientBase.h

Issue 6012307226230784: Issue #1234 - std::wstring version of UnescapeUrl (Closed)
Patch Set: Created Sept. 30, 2014, 3:21 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/plugin/PluginClientBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/plugin/PluginClientBase.h
===================================================================
--- a/src/plugin/PluginClientBase.h
+++ b/src/plugin/PluginClientBase.h
@@ -76,5 +76,14 @@
static bool PopFirstPluginError(CPluginError& pluginError);
};
+/**
+ * Wrapper around Microsoft API 'UrlUnescape'
+ *
+ * This function has modify-in-place semantics.
+ * This behavior matches that of the legacy version of this function declared above.
+ * At present, callers of this function have no code to handle error conditions that might arise here.
+ * Because there's no error handling, therefore, this masks failures in UrlUnescape.
+ */
+void UnescapeUrl(std::wstring& url);
#endif // _PLUGIN_CLIENT_BASE_H_
« no previous file with comments | « no previous file | src/plugin/PluginClientBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld