Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6013081427640320: Issue 537 - Mark first few downloads (Closed)

Created:
Nov. 10, 2014, 5:57 p.m. by Thomas Greiner
Modified:
Nov. 12, 2014, 10:06 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 537 - Mark subsequent downloads

Patch Set 1 #

Total comments: 15

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M lib/downloader.js View 1 2 3 chunks +14 lines, -1 line 0 comments Download
M lib/notification.js View 1 2 chunks +3 lines, -0 lines 0 comments Download
M lib/subscriptionClasses.js View 1 2 4 chunks +17 lines, -7 lines 0 comments Download
M lib/synchronizer.js View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Thomas Greiner
http://codereview.adblockplus.org/6013081427640320/diff/5629499534213120/lib/downloader.js File lib/downloader.js (right): http://codereview.adblockplus.org/6013081427640320/diff/5629499534213120/lib/downloader.js#newcode391 lib/downloader.js:391: downloadCount: 1, This number is always one higher than ...
Nov. 10, 2014, 6:14 p.m. (2014-11-10 18:14:55 UTC) #1
Wladimir Palant
Note that unit tests need to be updated as well. http://codereview.adblockplus.org/6013081427640320/diff/5629499534213120/lib/downloader.js File lib/downloader.js (right): http://codereview.adblockplus.org/6013081427640320/diff/5629499534213120/lib/downloader.js#newcode297 ...
Nov. 10, 2014, 7:18 p.m. (2014-11-10 19:18:15 UTC) #2
Thomas Greiner
I'm going to work on the unit tests right after that review is done. http://codereview.adblockplus.org/6013081427640320/diff/5629499534213120/lib/downloader.js ...
Nov. 11, 2014, 11:54 a.m. (2014-11-11 11:54:46 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/6013081427640320/diff/5629499534213120/lib/downloader.js File lib/downloader.js (right): http://codereview.adblockplus.org/6013081427640320/diff/5629499534213120/lib/downloader.js#newcode297 lib/downloader.js:297: downloadable.downloadCount = "5+"; On 2014/11/11 11:54:46, Thomas Greiner wrote: ...
Nov. 11, 2014, 4:07 p.m. (2014-11-11 16:07:00 UTC) #4
Thomas Greiner
http://codereview.adblockplus.org/6013081427640320/diff/5629499534213120/lib/downloader.js File lib/downloader.js (right): http://codereview.adblockplus.org/6013081427640320/diff/5629499534213120/lib/downloader.js#newcode297 lib/downloader.js:297: downloadable.downloadCount = "5+"; On 2014/11/11 16:07:00, Wladimir Palant wrote: ...
Nov. 11, 2014, 5:17 p.m. (2014-11-11 17:17:17 UTC) #5
Wladimir Palant
http://codereview.adblockplus.org/6013081427640320/diff/5717271485874176/lib/downloader.js File lib/downloader.js (right): http://codereview.adblockplus.org/6013081427640320/diff/5717271485874176/lib/downloader.js#newcode196 lib/downloader.js:196: if (downloadable.downloadCount > 4) No need to reference downloadable ...
Nov. 11, 2014, 5:28 p.m. (2014-11-11 17:28:15 UTC) #6
Thomas Greiner
http://codereview.adblockplus.org/6013081427640320/diff/5717271485874176/lib/downloader.js File lib/downloader.js (right): http://codereview.adblockplus.org/6013081427640320/diff/5717271485874176/lib/downloader.js#newcode196 lib/downloader.js:196: if (downloadable.downloadCount > 4) On 2014/11/11 17:28:16, Wladimir Palant ...
Nov. 11, 2014, 5:53 p.m. (2014-11-11 17:53:18 UTC) #7
Wladimir Palant
Nov. 11, 2014, 6:47 p.m. (2014-11-11 18:47:30 UTC) #8
LGTM, thank you.

Powered by Google App Engine
This is Rietveld