pages/jobs.tmpl - Issue 6034776070815744: Used history API and prevent scrolling to anchor when opening a job link

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: pages/jobs.tmpl

Issue 6034776070815744: Used history API and prevent scrolling to anchor when opening a job link (Closed)

Patch Set: Don't use history API for compatibility with ancient browsers ;P Created Jan. 10, 2014, 10:02 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: pages/jobs.tmpl

===================================================================

--- a/pages/jobs.tmpl

+++ b/pages/jobs.tmpl

@@ -16,7 +16,10 @@

{

var hash = ui.newTab.find("a")[0].hash;

if (hash != "#jobs-overview")

+ {

location.hash = hash;

+ window.scrollTo(0, 0);

+ }

}

})

).addClass("ui-tabs-nav-vertical");

@@ -29,6 +32,8 @@

var escapedHash = hash.replace(/\+/g, "\\+");

jQuery("[href=" + escapedHash + "]").click();

});

+ setTimeout(function() { window.scrollTo(0, 0); }, 0);

});

</script>

« no previous file with comments | « no previous file | no next file » | no next file with comments »