Issue 356 - Fixed auth token used to publish devbuild on the Chrome Web Store

sitescripts/extensions/bin/createNightlies.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2014 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 372 matching lines @@
       'https://accounts.google.com/o/oauth2/token',
 
       urlencode([
         ('refresh_token', self.config.refreshToken),
         ('client_id', self.config.clientID),
         ('client_secret', self.config.clientSecret),
         ('grant_type', 'refresh_token'),
       ])
     ))
 
+    auth_token = '%s %s' % (response['token_type'], response['access_token'])
+
     # upload a new version with the Chrome Web Store API
     # https://developer.chrome.com/webstore/using_webstore_api#uploadexisitng
 
     request = urllib2.Request('https://www.googleapis.com/upload/chromewebstore/v1.1/items/' + self.config.devbuildGalleryID)
     request.get_method = lambda: 'PUT'
-    request.add_header('Authorization', '%s %s' % (response['token_type'], response['access_token']))
+    request.add_header('Authorization', auth_token)
     request.add_header('x-goog-api-version', '2')
 
     with open(self.path, 'rb') as file:
       if file.read(8) != 'Cr24\x02\x00\x00\x00':
         raise Exception('not a chrome extension or unknown CRX version')
 
       # skip public key and signature
       file.seek(sum(struct.unpack('<II', file.read(8))), os.SEEK_CUR)
 
       request.add_header('Content-Length', os.fstat(file.fileno()).st_size - file.tell())
       request.add_data(file)
 
       response = json.load(urllib2.urlopen(request))
 
     if response['uploadState'] == 'FAILURE':
       raise Exception(response['itemError'])
 
     # publish the new version on the Chrome Web Store
     # https://developer.chrome.com/webstore/using_webstore_api#publishpublic
 
     request = urllib2.Request('https://www.googleapis.com/upload/chromewebstore/v1.1/items/%s/publish' % self.config.devbuildGalleryID)
     request.get_method = lambda: 'POST'
-    request.add_header('Authorization', '%s %s' % (response['token_type'], response['access_token']))
+    request.add_header('Authorization', auth_token)
     request.add_header('x-goog-api-version', '2')
     request.add_header('Content-Length', '0')
 
     response = json.load(urllib2.urlopen(request))
 
     if any(status != 'ITEM_PENDING_REVIEW' for status in response['status']):
       raise Exception(response['statusDetail'])
 
   def run(self):
     """
@@ skipping 73 matching lines @@
     except Exception, ex:
       print >>sys.stderr, "The build for %s failed:" % repo
       traceback.print_exc()
 
   file = open(nightlyConfigFile, 'wb')
   nightlyConfig.write(file)
 
 
 if __name__ == '__main__':
   main()