Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/ext/background.js

Issue 6098518317989888: Fix: Notification popup is broken (Closed)
Left Patch Set: Changes after Thomas notes Created Feb. 18, 2014, 10:13 a.m.
Right Patch Set: Change back activeNotification unset Created Feb. 26, 2014, 6:31 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
572 { 572 {
573 if (isContextMenuHidden) 573 if (isContextMenuHidden)
574 return; 574 return;
575 575
576 chrome.contextMenus.removeAll(); 576 chrome.contextMenus.removeAll();
577 isContextMenuHidden = true; 577 isContextMenuHidden = true;
578 } 578 }
579 }; 579 };
580 580
581 ext.onMessage = new BackgroundMessageEventTarget(); 581 ext.onMessage = new BackgroundMessageEventTarget();
582 // Chrome on Linux does not fully support chrome.notifications yet ( https://c ode.google.com/p/chromium/issues/detail?id=291485 )
583 if ("notifications" in chrome && navigator.platform.indexOf("Linux") == -1)
584 ext.browserNotifications = chrome.notifications;
Sebastian Noack 2014/02/28 09:56:03 This doesn't belong into the abstraction layer, si
Thomas Greiner 2014/02/28 10:10:55 Without having further looked into it Safari does
Sebastian Noack 2014/02/28 10:19:45 No, it is not for Safari, but for Mac OS. It looks
saroyanm 2014/02/28 11:18:43 Guys not that much know about safari extension dev
Sebastian Noack 2014/02/28 12:35:03 What Thomas suggested was Mac OS stuff, which we c
saroyanm 2014/02/28 13:47:04 Now I see your point Sebastian, make sense. What y
Thomas Greiner 2014/02/28 16:04:14 If there is actually no Safari-specific implementa
Sebastian Noack 2014/02/28 16:59:22 Not for rich notfications with UI elements and stu
582 })(); 585 })();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld