Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/WebRequestJsObject.cpp

Issue 6112412478472192: Issue 1547 - Pass isolate to v8::API (Closed)
Patch Set: rebase and move 'isolate' into the proper scopes Created Feb. 5, 2015, 3:18 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/GlobalJsObject.cpp ('K') | « src/Utils.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/WebRequestJsObject.cpp
diff --git a/src/WebRequestJsObject.cpp b/src/WebRequestJsObject.cpp
index e3709448842acef824e9a2474e927f1e52d8e833..bd169b8153d10c7492fc5814cfd41825803a80a8 100644
--- a/src/WebRequestJsObject.cpp
+++ b/src/WebRequestJsObject.cpp
@@ -21,6 +21,7 @@
#include "JsContext.h"
#include "Thread.h"
+#include "Utils.h"
#include "WebRequestJsObject.h"
namespace
@@ -90,6 +91,7 @@ namespace
v8::Handle<v8::Value> GETCallback(const v8::Arguments& arguments)
{
WebRequestThread* thread;
+
Felix Dahlke 2015/02/06 04:17:27 Unrelated as well.
try
{
AdblockPlus::JsEnginePtr jsEngine = AdblockPlus::JsEngine::FromArguments(arguments);
@@ -100,7 +102,9 @@ namespace
}
catch (const std::exception& e)
{
- return v8::ThrowException(v8::String::New(e.what()));
+ using AdblockPlus::Utils::ToV8String;
+ v8::Isolate* isolate = arguments.GetIsolate();
+ return v8::ThrowException(ToV8String(isolate, e.what()));
}
thread->Start();
return v8::Undefined();
« src/GlobalJsObject.cpp ('K') | « src/Utils.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld