Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6116696976785408: Issue 1590 - Add devenv support for Safari (Closed)

Created:
Nov. 21, 2014, 10:32 a.m. by Sebastian Noack
Modified:
Nov. 26, 2014, 7:27 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1590 - Add devenv support for Safari

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M build.py View 3 chunks +18 lines, -4 lines 0 comments Download
M packagerChrome.py View 1 chunk +0 lines, -9 lines 0 comments Download
M packagerSafari.py View 3 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
Nov. 21, 2014, 10:32 a.m. (2014-11-21 10:32:59 UTC) #1
Wladimir Palant
I'm pretty sure I had something in mind when I decided to not remove the ...
Nov. 26, 2014, 7:09 p.m. (2014-11-26 19:09:23 UTC) #2
Sebastian Noack
Nov. 26, 2014, 7:19 p.m. (2014-11-26 19:19:21 UTC) #3
On 2014/11/26 19:09:23, Wladimir Palant wrote:
> I'm pretty sure I had something in mind when I decided to not remove the
devenv
> directory on updates... Anyway, LGTM.

Theoretically, the Chrome extension could poll devenvVersion__ while it doesn't
exist. However, we should definitely remove files that exist only on Safari when
switching to Chrome and vice versa. And that case can/should be easily handled
in chromeDevenvPoller__.js.

Powered by Google App Engine
This is Rietveld