Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6122106488094720: Issue 1495 - Introduce $sitescriptsini_content in Puppet sitescripts module (Closed)

Created:
Nov. 26, 2014, 2:14 p.m. by mathias
Modified:
Jan. 5, 2015, 10:17 a.m.
Reviewers:
Wladimir Palant
CC:
Felix Dahlke, aalvz, paco
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/1495. Note that there's a duplicate of this review ticket (http://codereview.adblockplus.org/5814178002501632/), obviously a confusion with the numbers on my side.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Issue 1405 - Introduce $sitescriptsini_content in Puppet sitescripts module #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M modules/sitescripts/manifests/init.pp View 1 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 7
mathias
Nov. 26, 2014, 2:14 p.m. (2014-11-26 14:14:05 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modules/sitescripts/manifests/init.pp File modules/sitescripts/manifests/init.pp (right): http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modules/sitescripts/manifests/init.pp#newcode18 modules/sitescripts/manifests/init.pp:18: ';' => $title, Why not: source => "$source$content" ? ...
Nov. 26, 2014, 10:47 p.m. (2014-11-26 22:47:08 UTC) #2
mathias
http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modules/sitescripts/manifests/init.pp File modules/sitescripts/manifests/init.pp (right): http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modules/sitescripts/manifests/init.pp#newcode18 modules/sitescripts/manifests/init.pp:18: ';' => $title, On 2014/11/26 22:47:09, Wladimir Palant wrote: ...
Nov. 26, 2014, 11:34 p.m. (2014-11-26 23:34:29 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modules/sitescripts/manifests/init.pp File modules/sitescripts/manifests/init.pp (right): http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modules/sitescripts/manifests/init.pp#newcode18 modules/sitescripts/manifests/init.pp:18: ';' => $title, On 2014/11/26 23:34:29, matze wrote: > ...
Dec. 8, 2014, 4:43 p.m. (2014-12-08 16:43:59 UTC) #4
mathias
Dec. 10, 2014, 12:50 p.m. (2014-12-10 12:50:43 UTC) #5
mathias
http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modules/sitescripts/manifests/init.pp File modules/sitescripts/manifests/init.pp (right): http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modules/sitescripts/manifests/init.pp#newcode18 modules/sitescripts/manifests/init.pp:18: ';' => $title, On 2014/12/08 16:44:00, Wladimir Palant wrote: ...
Dec. 10, 2014, 12:51 p.m. (2014-12-10 12:51:04 UTC) #6
Wladimir Palant
Dec. 11, 2014, 4:47 p.m. (2014-12-11 16:47:34 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld