Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6150424264441856: Issue 2406 - Update pinned Nginx version to 1.8.0-1~precise (Closed)

Created:
April 23, 2015, 1:27 a.m. by mathias
Modified:
April 29, 2015, 8:51 a.m.
CC:
Fred
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/2406 for more information.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M modules/nginx/manifests/init.pp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
mathias
April 23, 2015, 1:27 a.m. (2015-04-23 01:27:51 UTC) #1
Felix Dahlke
LGTM, assuming we roll this out carefully.
April 23, 2015, 7:44 a.m. (2015-04-23 07:44:09 UTC) #2
mathias
On 2015/04/23 07:44:09, Felix H. Dahlke wrote: > LGTM, assuming we roll this out carefully. ...
April 23, 2015, 8:23 a.m. (2015-04-23 08:23:21 UTC) #3
Wladimir Palant
On 2015/04/23 08:23:21, matze wrote: > ... and preparing this patch-set, I've first checked that ...
April 23, 2015, 11:19 a.m. (2015-04-23 11:19:51 UTC) #4
mathias
April 23, 2015, 11:28 a.m. (2015-04-23 11:28:57 UTC) #5
On 2015/04/23 11:19:51, Wladimir Palant wrote:
> On 2015/04/23 08:23:21, matze wrote:
> > ... and preparing this patch-set, I've first checked that Travis-CI now
works
> as
> > expected
> 
> This means exactly nothing. Provisioning didn't fail, that's great. It doesn't
> mean however that our nginx configuration continues to work as it should.
> Personally, my idea was waiting for nginx 1.8.1 before rolling this out - the
> current version has lots of changes that haven't been tested by a wide
audience
> yet. We'll need time to test the VMs anyway.

I did not claim that this is enough testing. But I do claim that this is part of
a careful process in the first place. So, "means exactly nothing" is a bit
insulting. And of course there is more testing required, and I am actually
working on that right now. It just would make no sense if the provisioning of
any Nginx-using host failed in the first place.

By the way, because of our current Puppet code and since we use the fabulous
Ubuntu, there is no short-term choice for us other than upgrading. The so-far
used version has vanished from the in-use APT resource, which caused the issue
reported in #2406 in the first place. I believe I mentioned before that many
Ubuntu package maintainers "latest s**t from head" practice is one of the major
reasons why I would never recommend using Ubuntu on a server in the first place.

Powered by Google App Engine
This is Rietveld