Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6182748523855872: Issue 1518 - Got rid of deprecated code using webkitNotifications (Closed)

Created:
Jan. 7, 2015, 4:04 p.m. by Sebastian Noack
Modified:
Jan. 13, 2015, 2:19 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1518 - Got rid of deprecated code using webkitNotifications

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Use addEventListener() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -68 lines) Patch
M background.js View 1 5 chunks +18 lines, -19 lines 0 comments Download
R chrome/notification.html View 1 chunk +0 lines, -46 lines 0 comments Download
M metadata.common View 1 chunk +0 lines, -1 line 0 comments Download
M webrequest.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Jan. 7, 2015, 4:06 p.m. (2015-01-07 16:06:48 UTC) #1
Wladimir Palant
Up to you whether you want to address the comment below but I would definitely ...
Jan. 13, 2015, 7:39 a.m. (2015-01-13 07:39:15 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/6182748523855872/diff/4863277368606720/background.js File background.js (right): http://codereview.adblockplus.org/6182748523855872/diff/4863277368606720/background.js#newcode421 background.js:421: notification.onclose = notificationClosed; On 2015/01/13 07:39:16, Wladimir Palant wrote: ...
Jan. 13, 2015, 12:30 p.m. (2015-01-13 12:30:20 UTC) #3
Wladimir Palant
Jan. 13, 2015, 12:59 p.m. (2015-01-13 12:59:27 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld