Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6193426550751232: Issue 2214 - Add message to Adblock Plus home page about mobile beta launch (Infrastructure) (Closed)

Created:
April 28, 2015, 4:51 p.m. by saroyanm
Modified:
May 29, 2015, 9:07 a.m.
Reviewers:
Thomas Greiner
CC:
Felix Dahlke, rossg, Wladimir Palant, Sebastian Noack
Visibility:
Public.

Description

Related ticket: https://issues.adblockplus.org/ticket/2214 Website implementation: http://codereview.adblockplus.org/5810237621665792/

Patch Set 1 #

Total comments: 3

Patch Set 2 : Merging styles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M anwiki/_override-static/global/global/css/index.css View 1 chunk +10 lines, -0 lines 0 comments Download
M anwiki/_override-static/global/global/css/index-desktop.css View 1 1 chunk +4 lines, -12 lines 0 comments Download
M anwiki/_override-static/global/global/css/index-mobile.css View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4
saroyanm
http://codereview.adblockplus.org/6193426550751232/diff/5629499534213120/anwiki/_override-static/global/global/css/index-desktop.css File anwiki/_override-static/global/global/css/index-desktop.css (left): http://codereview.adblockplus.org/6193426550751232/diff/5629499534213120/anwiki/_override-static/global/global/css/index-desktop.css#oldcode73 anwiki/_override-static/global/global/css/index-desktop.css:73: html[lang="fr"] .warning-platform, Now we have top level warning message, ...
April 28, 2015, 5:08 p.m. (2015-04-28 17:08:34 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/6193426550751232/diff/5629499534213120/anwiki/_override-static/global/global/css/index-desktop.css File anwiki/_override-static/global/global/css/index-desktop.css (right): http://codereview.adblockplus.org/6193426550751232/diff/5629499534213120/anwiki/_override-static/global/global/css/index-desktop.css#newcode76 anwiki/_override-static/global/global/css/index-desktop.css:76: float: right; Don't duplicate styles. Rather add "#adblock-browser-notification" to ...
April 29, 2015, 11:55 a.m. (2015-04-29 11:55:22 UTC) #2
saroyanm
Patch Set 2 : Merging styles http://codereview.adblockplus.org/6193426550751232/diff/5629499534213120/anwiki/_override-static/global/global/css/index-desktop.css File anwiki/_override-static/global/global/css/index-desktop.css (right): http://codereview.adblockplus.org/6193426550751232/diff/5629499534213120/anwiki/_override-static/global/global/css/index-desktop.css#newcode76 anwiki/_override-static/global/global/css/index-desktop.css:76: float: right; On ...
April 29, 2015, 12:33 p.m. (2015-04-29 12:33:29 UTC) #3
Thomas Greiner
April 29, 2015, 1:42 p.m. (2015-04-29 13:42:14 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld