block.html - Issue 6194726097125376: Issue 731 - Don't wrap filter in "Block element" dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: block.html

Issue 6194726097125376: Issue 731 - Don't wrap filter in "Block element" dialog (Closed)

Patch Set: Created June 28, 2014, 1:14 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2	2

3 <!--	3 <!--

4 - This file is part of Adblock Plus <http://adblockplus.org/>,	4 - This file is part of Adblock Plus <http://adblockplus.org/>,

5 - Copyright (C) 2006-2014 Eyeo GmbH	5 - Copyright (C) 2006-2014 Eyeo GmbH

6 -	6 -

7 - Adblock Plus is free software: you can redistribute it and/or modify	7 - Adblock Plus is free software: you can redistribute it and/or modify

8 - it under the terms of the GNU General Public License version 3 as	8 - it under the terms of the GNU General Public License version 3 as

9 - published by the Free Software Foundation.	9 - published by the Free Software Foundation.

10 -	10 -

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
67 }	67 }

68 </style>	68 </style>

69 </head>	69 </head>

70 <body draggable="true">	70 <body draggable="true">

71	71

72 <div id="title">	72 <div id="title">

73 <img src="icons/abp-32.png" />	73 <img src="icons/abp-32.png" />

74 <span class="i18n_add_filters_msg"></span>	74 <span class="i18n_add_filters_msg"></span>

75 </div>	75 </div>

76	76

77 <textarea id="filters"></textarea>	77 <textarea id="filters" wrap="off"></textarea>
	Thomas Greiner 2014/09/30 10:37:00 This works but the "off" value doesn't appear to b This works but the "off" value doesn't appear to be in the standard. We can achieve the same effect with CSS using: white-space: pre; word-wrap: normal; Sebastian Noack 2014/10/01 18:15:08 Well, it is in the standard: https://html.spec.wha Show quoted text On 2014/09/30 10:37:00, Thomas Greiner wrote: > This works but the "off" value doesn't appear to be in the standard. We can > achieve the same effect with CSS using: > > white-space: pre; > word-wrap: normal; Well, it is in the standard: https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-wrap It's also documented on MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-wrap Wladimir Palant 2014/10/01 18:35:51 Either I am overlooking something or both pages on Show quoted text On 2014/10/01 18:15:08, Sebastian Noack wrote: > Well, it is in the standard: > https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-wrap > > It's also documented on MDN: > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-wrap Either I am overlooking something or both pages only document wrap="hard" and wrap="soft" but not wrap="off". This value indeed appears to be non-standard and deprecated. Sebastian Noack 2014/10/29 12:17:05 No, I overlooked it, you both were right. I'm usin Show quoted text On 2014/10/01 18:35:51, Wladimir Palant wrote: > On 2014/10/01 18:15:08, Sebastian Noack wrote: > > Well, it is in the standard: > > https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-wrap > > > > It's also documented on MDN: > > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-wrap > > Either I am overlooking something or both pages only document wrap="hard" and > wrap="soft" but not wrap="off". This value indeed appears to be non-standard and > deprecated. No, I overlooked it, you both were right. I'm using standard CSS properties now, as suggested by Thomas.
78	78

79 <div id="buttons">	79 <div id="buttons">

80 <button id="addButton" class="i18n_add"></button>	80 <button id="addButton" class="i18n_add"></button>

81 <button id="cancelButton" class="i18n_cancel"></button>	81 <button id="cancelButton" class="i18n_cancel"></button>

82 </div>	82 </div>

83	83

84 </body>	84 </body>

85 </html>	85 </html>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »