Issue 1181 - Change polyfill for IE8 (fix settings page)

html/static/js/ieEventListenerPolyfill.js

Index: html/static/js/ieEventListenerPolyfill.js
===================================================================
--- a/html/static/js/ieEventListenerPolyfill.js
+++ b/html/static/js/ieEventListenerPolyfill.js
@@ -1,14 +1,14 @@
-if (typeof window.addEventListener != "function")

[Felix Dahlke, 2014/08/08 12:34:08]

I'm not sure why this works in IE8 frankly, window shouldn't have anything from
Element.prototype, and we're explicitly invoking window.addEventListener.

But that's easy to fix, this should do:

if (Window)
{
  Window.prototype.addEventListener = Element.prototype.addEventListener;
  Window.prototype.removeEventListener = Element.prototype.removeEventListener;
}

From:
https://developer.mozilla.org/en/docs/Web/API/EventTarget.addEventListener#Ol...

[Oleksandr, 2014/08/08 13:11:06]

It actually wasn't working on firstrun page, my bad. I have modified your
suggestion a bit, wouldn't be good to replace addEventListener if it was already
implemented (IE9+).

Also, since there was 2 "load" even handlers, where one was expecting another
one to run first, I have combined them into one.
On 2014/08/08 12:34:08, Felix H. Dahlke wrote:

+if (typeof Element.prototype.addEventListener != "function")
 {
-  window.addEventListener = function(type, handler, capture)
+  Element.prototype.addEventListener = function(type, handler, capture)
   {
     this.attachEvent("on" + type, handler)
   };
 }
 
-if (typeof window.removeEventListener != "function")
+if (typeof Element.prototype.removeEventListener != "function")
 {
-  window.removeEventListener = function(type, handler)
+  Element.prototype.removeEventListener = function(type, handler)
   {
     this.detachEvent("on" + type, handler)
   };