Whole installer

Whole installer. Since rietveld can't handle an upload of a review with a lot of files I have removed the localization files (installer/src/msi/locale folder). There wasn't much sense in reviewing that anyway.

[Felix Dahlke, 2014-08-07 15:15:04]

Doing a full review of this before the release is not realistic, so I tried to
do a very high level review for now. Only one comment came up so far, see below.

But what's evident is that this will need a _lot_ of work. I've created a
cleanup meta issue for that:
https://issues.adblockplus.org/ticket/1184

The review is far from done, I've only scratched the surface. We should add
issues as we review.

http://codereview.adblockplus.org/6202981292703744/diff/5629499534213120/buil...
File build_release.py (left):

http://codereview.adblockplus.org/6202981292703744/diff/5629499534213120/buil...
build_release.py:69: bundle = os.path.join(basedir, "build",
"adblockplusie-%s.exe" % version)
Why don't we sign the individual .exes anymore? Is signing the MSIs and
installer sufficient?

[Eric, 2014-08-07 15:52:35]

http://codereview.adblockplus.org/6202981292703744/diff/5629499534213120/buil...
File build_release.py (left):

http://codereview.adblockplus.org/6202981292703744/diff/5629499534213120/buil...
build_release.py:69: bundle = os.path.join(basedir, "build",
"adblockplusie-%s.exe" % version)
On 2014/08/07 15:15:04, Felix H. Dahlke wrote:
> Why don't we sign the individual .exes anymore? Is signing the MSIs and
> installer sufficient?

Wladimir figured out the signing issues a year ago on first release, which was
using WiX burn. WiX burn is too problematic for a number of reasons for
packaging MSI's, so Oleksandr switched just that one part over to InnoSetup. The
new signing tool is from InnoSetup. At the very least, it has different syntax.

I can't say whether it's the right kind of signing or not.

One thing we had talked about but have not done yet (to my knowledge) is to
generate a development-only signing key, checked into version control, that we
can use to test the signing procedure.