Issue 212 - Update Discourse

modules/discourse/manifests/init.pp

 class discourse(
     $domain,
-    $is_default = false) inherits private::discourse {

[Felix Dahlke, 2014/03/27 15:49:11]

Nit: We usually break before ")" in argument lists, I think.

[Wladimir Palant, 2014/03/27 20:28:24]

From what I can tell, the only other occasions are nginx (there we have a line
break) and trac (there we don't have it). But I guess having a line break would
be consistent with the usual Puppet style, done. We might want to change it in
the Trac module as well when we touch it.

+    $is_default = false
+  ) inherits private::discourse {
+
   include postgresql::server
 
   postgresql::database {'discourse':}
 
   postgresql::role {'discourse':
     password_hash => $database_password,
     db => 'discourse',
     login => true,
     superuser => true,
     require => Postgresql::Database['discourse']
   }
 
-  package {['postgresql-contrib', 'redis-server', 'ruby1.9.1', 'libjemalloc1', 'imagemagick']:
+  $basic_dependencies = ['postgresql-contrib', 'redis-server', 'ruby1.9.1',
+      'libjemalloc1', 'curl']
+  $gem_dependencies = ['git', 'build-essential', 'ruby1.9.1-dev', 'libxml2-dev',
+      'libxslt-dev', 'libpq-dev']
+  $image_optim_dependencies = ['advancecomp', 'gifsicle', 'jhead', 'jpegoptim',
+      'libjpeg-progs', 'optipng', 'pngcrush']
+  $image_sorcery_dependencies = 'imagemagick'
+
+  package {[$basic_dependencies, $gem_dependencies, $image_optim_dependencies, $image_sorcery_dependencies]:
     ensure => present
   }
 
   Exec {path => '/bin:/usr/bin:/usr/sbin:/usr/local/bin'}
 
   exec {'update-alternatives --set ruby "/usr/bin/ruby1.9.1"':
     unless => 'test $(readlink "/etc/alternatives/ruby") == "/usr/bin/ruby1.9.1"',
     require => Package['ruby1.9.1']
   }
 
   exec {'update-alternatives --set gem "/usr/bin/gem1.9.1"':
     unless => 'test $(readlink "/etc/alternatives/gem") == "/usr/bin/gem1.9.1"',
     require => Package['ruby1.9.1'],
-    before => Exec['/usr/bin/gem update --system 1.8.25']
-  }
-
-  exec {'/usr/bin/gem update --system 1.8.25':
+    before => Exec['update_gem']
+  }
+
+  exec {'update_gem':
+    command => '/usr/bin/gem update --system 1.8.25',
     unless => 'test $(gem -v) == "1.8.25"',
     environment => 'REALLY_GEM_UPDATE_SYSTEM=1',
-    before => Package['bundler'],
   }
 
   package {'bundler':
     ensure => present,
-    provider => gem
-  }
-
-  $gem_dependencies = ['git', 'build-essential', 'ruby1.9.1-dev', 'libxml2-dev',
-                       'libxslt-dev', 'libpq-dev']
-  package {$gem_dependencies: ensure => present}
-
-  file {['/opt/discourse', '/opt/discourse/tmp', '/opt/discourse/tmp/pids']:
+    provider => gem,
+    require => Exec['update_gem']
+  }
+
+  file {'/opt/discourse':
     ensure => directory,
     mode => 755,
     owner => discourse,
     group => www-data
+  }
+
+  file {['/opt/discourse/tmp', '/opt/discourse/tmp/pids']:
+    ensure => directory,
+    mode => 755,
+    owner => discourse,
+    group => www-data,
+    require => Exec['fetch-discourse']
   }
 
   file {'/opt/discourse/config/discourse.conf':
     mode => 600,
     owner => discourse,
     group => www-data,
     content => template('discourse/discourse.conf.erb'),
     notify => Service['discourse'],
     require => Exec['fetch-discourse']
   }
@@ skipping 34 matching lines @@
   }
 
   exec {'/usr/local/bin/init-discourse':
     subscribe => File['/usr/local/bin/init-discourse'],
     refreshonly => true,
     environment => ["AIRBRAKE_KEY=${airbrake_key}"],
     user => discourse,
     group => www-data,
     timeout => 0,
     logoutput => true,
-    require => [Package['bundler', 'postgresql-contrib', $gem_dependencies],
+    require => [Package['bundler', $gem_dependencies],
                 User['discourse'], File['/etc/sudoers.d/discourse'],
                 Exec['fetch-discourse'],
                 File['/opt/discourse/config/discourse.conf'],
                 Postgresql::Role['discourse']]
   }
 
   Discourse::Sitesetting <| |> {
     require => Exec['/usr/local/bin/init-discourse']
   }
 
@@ skipping 38 matching lines @@
     type => 1,
     value => ''
   }
 
   discourse::sitesetting {'email_domains_whitelist':
     ensure => present,
     type => 1,
     value => 'adblockplus.org|eyeo.com'
   }
 
-  discourse::sitesetting {'use_ssl':
+  discourse::sitesetting {'use_https':
     ensure => present,
     type => 5,
     value => 't'
   }
 
   discourse::sitesetting {'company_full_name':
     ensure => present,
     type => 1,
     value => 'Eyeo GmbH'
   }
@@ skipping 45 matching lines @@
     type => 5,
     value => 'f'
   }
 
   discourse::sitesetting {'enforce_global_nicknames':
     ensure => present,
     type => 5,
     value => 'f'
   }
 
-  Discourse::Postactiontype <| |> {
-    require => Exec['/usr/local/bin/init-discourse']
-  }
-
-  discourse::postactiontype {'bookmark':
-    ensure => present,
-    id => 1,
-    position => 1
-  }
-
-  discourse::postactiontype {'like':
-    ensure => present,
-    id => 2,
-    position => 2,
-    icon => 'heart'
-  }
-
-  discourse::postactiontype {'off_topic':
-    ensure => present,
-    id => 3,
-    position => 3,
-    is_flag => true
-  }
-
-  discourse::postactiontype {'inappropriate':
-    ensure => present,
-    id => 4,
-    position => 4,
-    is_flag => true
-  }
-
-  discourse::postactiontype {'vote':
-    ensure => present,
-    position => 5,
-    id => 5
-  }
-
-  discourse::postactiontype {'custom_flag':
-    ensure => present,
-    id => 6,
-    position => 7,
-    is_flag => true
-  }
-
-  discourse::postactiontype {'spam':
-    ensure => present,
-    id => 7,
-    position => 6,
-    is_flag => true
+  discourse::sitesetting {'allow_user_locale':
+    ensure => present,
+    type => 5,
+    value => 't'
+  }
+
+  discourse::sitesetting {'white_listed_spam_host_domains':
+    ensure => present,
+    type => 1,
+    value => 'adblockplus.org,eyeo.com'
   }
 
   Discourse::Customservice <| |> {
     user => 'discourse',
     workdir => '/opt/discourse',
     env => ['RAILS_ENV=production', 'RUBY_GC_MALLOC_LIMIT=90000000',
       'UNICORN_WORKERS=2', 'LD_PRELOAD=/usr/lib/libjemalloc.so.1'],
     require => Exec['/usr/local/bin/init-discourse']
   }
 
@@ skipping 32 matching lines @@
     content => template('discourse/site.erb'),
     enabled => true
   }
 
   file {"/etc/logrotate.d/nginx_$domain":
     ensure => file,
     require => Nginx::Hostconfig[$domain],
     source => 'puppet:///modules/discourse/logrotate'
   }
 }