Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6228524553732096: Issue 1713 - (Disable/Enable on ...) not showing on FF Mobile (Closed)

Created:
Dec. 21, 2014, 10:53 p.m. by saroyanm
Modified:
Dec. 29, 2014, 11:38 a.m.
Reviewers:
Wladimir Palant
CC:
Philip Hill
Visibility:
Public.

Description

This review is related to current ticket: https://issues.adblockplus.org/ticket/1713

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M lib/appSupport.js View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4
saroyanm
Wladimir can you please have a look when you have time, looks to be a ...
Dec. 21, 2014, 10:56 p.m. (2014-12-21 22:56:04 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6228524553732096/diff/5629499534213120/lib/appSupport.js File lib/appSupport.js (right): http://codereview.adblockplus.org/6228524553732096/diff/5629499534213120/lib/appSupport.js#newcode708 lib/appSupport.js:708: window.addEventListener("UIReady", this.attach.bind(this), false); This listener needs to be removed ...
Dec. 28, 2014, 11:28 a.m. (2014-12-28 11:28:23 UTC) #2
saroyanm
http://codereview.adblockplus.org/6228524553732096/diff/5629499534213120/lib/appSupport.js File lib/appSupport.js (right): http://codereview.adblockplus.org/6228524553732096/diff/5629499534213120/lib/appSupport.js#newcode708 lib/appSupport.js:708: window.addEventListener("UIReady", this.attach.bind(this), false); On 2014/12/28 11:28:23, Wladimir Palant wrote: ...
Dec. 28, 2014, 7:30 p.m. (2014-12-28 19:30:14 UTC) #3
Wladimir Palant
Dec. 29, 2014, 9:46 a.m. (2014-12-29 09:46:28 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld