Issue 2239 - Make logprocessor close files and wait for subprocesses

sitescripts/stats/bin/logprocessor.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2015 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 48 matching lines @@
         command[1:1] = ["-P", str(parseresult.port)]
       ssh_process = subprocess.Popen(command, stdout=subprocess.PIPE)
       self._processes.push(ssh_process)
       self._file = ssh_process.stdout
     elif parseresult.scheme in ("http", "https"):
       self._file = urllib.urlopen(path)
     elif os.path.exists(path):
       self._file = open(path, "rb")
     else:
       raise IOError("Path '%s' not recognized" % path)
-
-    self._files.append(result)
 
     if path.endswith(".gz"):
       # Built-in gzip module doesn't support streaming (fixed in Python 3.2)
       gzip_process = subprocess.Popen(["gzip", "-cd"], stdin=self._file, stdout=subprocess.PIPE)
       self._processes.append(gzip_process)
       self._file, self._inner_file = gzip_process.stdout, self._file
 
   def __getattr__(self, name):
     return getattr(self._file, name)
 
@@ skipping 485 matching lines @@
   parser.add_argument("mirror_name", nargs="?", help="Name of the mirror server that the file belongs to")
   parser.add_argument("server_type", nargs="?", help="Server type like download, update or subscription")
   parser.add_argument("log_file", nargs="?", help="Log file path, can be a local file path, http:// or ssh:// URL")
   args = parser.parse_args()
 
   if args.mirror_name and args.server_type and args.log_file:
     sources = [(args.mirror_name, args.server_type, args.log_file)]
   else:
     sources = get_stats_files()
   parse_sources(sources, args.factor, args.verbose)