src/plugin/NotificationMessage.cpp - Issue 6237450183639040: Issue 1283 - wrong usage of memset, fix sizeof, make proper initializing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/plugin/NotificationMessage.cpp

Issue 6237450183639040: Issue 1283 - wrong usage of memset, fix sizeof, make proper initializing (Closed)

Patch Set: Created Sept. 1, 2014, 11:52 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/plugin/NotificationMessage.cpp

===================================================================

--- a/src/plugin/NotificationMessage.cpp

+++ b/src/plugin/NotificationMessage.cpp

@@ -16,7 +16,7 @@

if (!commonControlsInitialized)

{

INITCOMMONCONTROLSEX commControls;

- commControls.dwSize = sizeof(INITCOMMONCONTROLSEX);

+ commControls.dwSize = sizeof(commControls);

commControls.dwICC = ICC_BAR_CLASSES;

InitCommonControlsEx(&commControls);

commonControlsInitialized = true;

@@ -39,7 +39,7 @@

SetWindowPos(toolTipWindow, HWND_TOPMOST,0, 0, 0, 0,

SWP_NOMOVE | SWP_NOSIZE | SWP_NOACTIVATE);

TOOLINFOW ti = {};

- ti.cbSize = sizeof(TOOLINFOW);

+ ti.cbSize = sizeof(ti);

ti.uFlags = TTF_IDISHWND | TTF_TRACK | TTF_TRANSPARENT;

ti.hwnd = parentWindow;

ti.hinst = NULL;

@@ -77,7 +77,7 @@

bool NotificationMessage::SetTextAndIcon(std::wstring text, std::wstring title, int icon)

{

TOOLINFOW ti = {};

- ti.cbSize = sizeof(TOOLINFOW);

+ ti.cbSize = sizeof(ti);

ti.hwnd = parentWindow;

ti.hinst = NULL;

ti.uId = (UINT_PTR)parentWindow;