Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include.preload.js

Issue 6238490647855104: Issue 498 - Don't use Shadow DOM on Chrome 31-33 (Closed)
Patch Set: Created May 16, 2014, 1:25 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include.preload.js
===================================================================
--- a/include.preload.js
+++ b/include.preload.js
@@ -21,10 +21,13 @@
// rely on the order of their own <style> tags. However
// the <shadow> element is broken in some Chrome 32 builds (#309)
//
+// also Chrome 31-33 crashes in some situations on some pages when using
+// ShadowDOM, e.g. when pressing tab key on Wikipedia and Facebook (#498)
+//
// also we must not create the shadow root in the response callback passed
// to sendMessage(), otherwise Chrome breaks some websites (#450)
var shadow = null;
-if ("webkitCreateShadowRoot" in document.documentElement && !/\bChrome\/32\b/.test(navigator.userAgent))
+if ("webkitCreateShadowRoot" in document.documentElement && !/\bChrome\/3[1-3]\b/.test(navigator.userAgent))
{
shadow = document.documentElement.webkitCreateShadowRoot();
shadow.appendChild(document.createElement("shadow"));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld