Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6270530592178176: Issue 1144 - Generate IE update manifests (Closed)

Created:
July 25, 2014, 1:01 p.m. by Felix Dahlke
Modified:
July 30, 2014, 2:58 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1144 - Generate IE update manifests

Patch Set 1 : #

Total comments: 9

Patch Set 2 : No template for update.json, document new settings #

Total comments: 10

Patch Set 3 : Import writeIEUpdateManifest as doWrite in the function body #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -33 lines) Patch
M .sitescripts.example View 1 2 chunks +4 lines, -0 lines 0 comments Download
M sitescripts/extensions/bin/createNightlies.py View 1 2 4 chunks +12 lines, -28 lines 0 comments Download
M sitescripts/extensions/bin/updateUpdateManifests.py View 1 4 chunks +15 lines, -5 lines 0 comments Download
M sitescripts/extensions/utils.py View 1 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 9
Felix Dahlke
July 25, 2014, 1:08 p.m. (2014-07-25 13:08:49 UTC) #1
Wladimir Palant
It seems that some changes were implemented to prevent a special code path for IE ...
July 29, 2014, 11:25 a.m. (2014-07-29 11:25:18 UTC) #2
Felix Dahlke
http://codereview.adblockplus.org/6270530592178176/diff/5649050225344512/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (left): http://codereview.adblockplus.org/6270530592178176/diff/5649050225344512/sitescripts/extensions/bin/createNightlies.py#oldcode210 sitescripts/extensions/bin/createNightlies.py:210: def writeLibabpUpdateManifest(self, updates): On 2014/07/29 11:25:18, Wladimir Palant wrote: ...
July 29, 2014, 11:37 a.m. (2014-07-29 11:37:16 UTC) #3
Felix Dahlke
As discussed on IRC, we want to move away from templates for manifests (RDF and ...
July 29, 2014, 11:47 a.m. (2014-07-29 11:47:58 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/6270530592178176/diff/5649050225344512/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/6270530592178176/diff/5649050225344512/sitescripts/extensions/bin/createNightlies.py#newcode224 sitescripts/extensions/bin/createNightlies.py:224: self.version = versions[0] On 2014/07/29 11:37:17, Felix H. Dahlke ...
July 29, 2014, 12:03 p.m. (2014-07-29 12:03:10 UTC) #5
Felix Dahlke
Uploaded a new patch set that generates update.json without using a template, as discussed. It'll ...
July 29, 2014, 3:10 p.m. (2014-07-29 15:10:27 UTC) #6
Wladimir Palant
http://codereview.adblockplus.org/6270530592178176/diff/5271204772446208/.sitescripts.example File .sitescripts.example (right): http://codereview.adblockplus.org/6270530592178176/diff/5271204772446208/.sitescripts.example#newcode103 .sitescripts.example:103: ieUpdateManifestPath=%(root)s/www/ieupdate.json Obsolete? http://codereview.adblockplus.org/6270530592178176/diff/5271204772446208/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/6270530592178176/diff/5271204772446208/sitescripts/extensions/bin/createNightlies.py#newcode223 sitescripts/extensions/bin/createNightlies.py:223: writeIEUpdateManifest(manifestPath, ...
July 30, 2014, 2:02 p.m. (2014-07-30 14:02:22 UTC) #7
Felix Dahlke
New patch set. http://codereview.adblockplus.org/6270530592178176/diff/5271204772446208/.sitescripts.example File .sitescripts.example (right): http://codereview.adblockplus.org/6270530592178176/diff/5271204772446208/.sitescripts.example#newcode103 .sitescripts.example:103: ieUpdateManifestPath=%(root)s/www/ieupdate.json On 2014/07/30 14:02:23, Wladimir Palant ...
July 30, 2014, 2:22 p.m. (2014-07-30 14:22:35 UTC) #8
Wladimir Palant
July 30, 2014, 2:37 p.m. (2014-07-30 14:37:50 UTC) #9
LGTM

http://codereview.adblockplus.org/6270530592178176/diff/5271204772446208/site...
File sitescripts/extensions/bin/updateUpdateManifests.py (right):

http://codereview.adblockplus.org/6270530592178176/diff/5271204772446208/site...
sitescripts/extensions/bin/updateUpdateManifests.py:73: 'basename':
os.path.basename(repo.repository)
On 2014/07/30 14:22:36, Felix H. Dahlke wrote:
> So, are you actually OK with this? Well, it does work.

Of course, it is a hack. However, there isn't really a way around it right now -
IE and Android don't have a metadata file that we could extract the basename
from. So at this point there isn't much we can do. Ideally, we would support IE
and Android in build tools properly.

Powered by Google App Engine
This is Rietveld