Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6273062181797888: Issue 505 - [Typed objects] Implement array helper methods (Closed)

Created:
May 17, 2014, 9:03 p.m. by Wladimir Palant
Modified:
July 11, 2014, 8:16 a.m.
Reviewers:
René Jeschke
CC:
Felix Dahlke, tschuster
Visibility:
Public.

Description

Issue 505 - [Typed objects] Implement array helper methods

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -0 lines) Patch
M lib/typedObjects.js View 1 chunk +7 lines, -0 lines 0 comments Download
M lib/typedObjects/arrayTypes.js View 1 2 chunks +80 lines, -0 lines 0 comments Download
M test/tests/typedObjects.js View 1 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
May 17, 2014, 9:03 p.m. (2014-05-17 21:03:33 UTC) #1
René Jeschke
http://codereview.adblockplus.org/6273062181797888/diff/5629499534213120/lib/typedObjects/arrayTypes.js File lib/typedObjects/arrayTypes.js (right): http://codereview.adblockplus.org/6273062181797888/diff/5629499534213120/lib/typedObjects/arrayTypes.js#newcode219 lib/typedObjects/arrayTypes.js:219: if (index < 0) What about the negative indexing ...
May 19, 2014, 8:35 a.m. (2014-05-19 08:35:53 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/6273062181797888/diff/5629499534213120/lib/typedObjects/arrayTypes.js File lib/typedObjects/arrayTypes.js (right): http://codereview.adblockplus.org/6273062181797888/diff/5629499534213120/lib/typedObjects/arrayTypes.js#newcode219 lib/typedObjects/arrayTypes.js:219: if (index < 0) On 2014/05/19 08:35:53, René Jeschke ...
May 19, 2014, 3:22 p.m. (2014-05-19 15:22:02 UTC) #3
René Jeschke
May 19, 2014, 3:27 p.m. (2014-05-19 15:27:26 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld