popupBlocker.js - Issue 6276084194607104: Issue 338 - Updated minimum version to Chrome 28 and got rid of legacy compatibility code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: popupBlocker.js

Issue 6276084194607104: Issue 338 - Updated minimum version to Chrome 28 and got rid of legacy compatibility code (Closed)

Patch Set: Created April 16, 2014, 9:54 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: popupBlocker.js

===================================================================

--- a/popupBlocker.js

+++ b/popupBlocker.js

@@ -15,7 +15,7 @@

* along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

-if (require("info").platform == "chromium" && "webNavigation" in chrome)

+if (require("info").platform == "chromium")

Wladimir Palant 2014/04/16 10:12:16 I think that this will break older Opera versions

Sebastian Noack 2014/04/16 10:14:11 Yes, this requires Opera >=17. However we are alre

{

var tabsLoading = {};

« no previous file with comments | « metadata.chrome ('k') | no next file » | no next file with comments »