Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6291923287408640: Issue 1093 - Separate update manifest generation (Closed)

Created:
July 22, 2014, 8:03 a.m. by Felix Dahlke
Modified:
July 23, 2014, 6:35 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1093 - Separate update manifest generation

Patch Set 1 #

Total comments: 21

Patch Set 2 : Address comments #

Total comments: 3

Patch Set 3 : Fix issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -206 lines) Patch
M sitescripts/extensions/bin/updateDownloadLinks.py View 1 2 chunks +2 lines, -205 lines 0 comments Download
A sitescripts/extensions/bin/updateUpdateManifests.py View 1 1 chunk +104 lines, -0 lines 0 comments Download
M sitescripts/extensions/utils.py View 1 2 2 chunks +142 lines, -1 line 0 comments Download

Messages

Total messages: 6
Felix Dahlke
http://codereview.adblockplus.org/6291923287408640/diff/5629499534213120/sitescripts/extensions/bin/updateUpdateManifests.py File sitescripts/extensions/bin/updateUpdateManifests.py (right): http://codereview.adblockplus.org/6291923287408640/diff/5629499534213120/sitescripts/extensions/bin/updateUpdateManifests.py#newcode30 sitescripts/extensions/bin/updateUpdateManifests.py:30: def writeUpdateManifest(links): This hasn't been changed, just moved. Since ...
July 22, 2014, 8:11 a.m. (2014-07-22 08:11:10 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6291923287408640/diff/5629499534213120/sitescripts/extensions/bin/updateDownloadLinks.py File sitescripts/extensions/bin/updateDownloadLinks.py (right): http://codereview.adblockplus.org/6291923287408640/diff/5629499534213120/sitescripts/extensions/bin/updateDownloadLinks.py#newcode26 sitescripts/extensions/bin/updateDownloadLinks.py:26: import sys, os, re, urllib, urllib2, subprocess, time sys, ...
July 22, 2014, 11:24 a.m. (2014-07-22 11:24:26 UTC) #2
Felix Dahlke
Uploaded a new patch set. http://codereview.adblockplus.org/6291923287408640/diff/5629499534213120/sitescripts/extensions/bin/updateDownloadLinks.py File sitescripts/extensions/bin/updateDownloadLinks.py (right): http://codereview.adblockplus.org/6291923287408640/diff/5629499534213120/sitescripts/extensions/bin/updateDownloadLinks.py#newcode26 sitescripts/extensions/bin/updateDownloadLinks.py:26: import sys, os, re, ...
July 22, 2014, 12:01 p.m. (2014-07-22 12:01:11 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/6291923287408640/diff/5629499534213120/sitescripts/extensions/bin/updateUpdateManifests.py File sitescripts/extensions/bin/updateUpdateManifests.py (right): http://codereview.adblockplus.org/6291923287408640/diff/5629499534213120/sitescripts/extensions/bin/updateUpdateManifests.py#newcode30 sitescripts/extensions/bin/updateUpdateManifests.py:30: def writeUpdateManifest(links): On 2014/07/22 12:01:11, Felix H. Dahlke wrote: ...
July 22, 2014, 6:41 p.m. (2014-07-22 18:41:22 UTC) #4
Felix Dahlke
New patch set. http://codereview.adblockplus.org/6291923287408640/diff/5122315436163072/sitescripts/extensions/utils.py File sitescripts/extensions/utils.py (right): http://codereview.adblockplus.org/6291923287408640/diff/5122315436163072/sitescripts/extensions/utils.py#newcode286 sitescripts/extensions/utils.py:286: document = dom.parseString(contents) On 2014/07/22 18:41:22, ...
July 23, 2014, 4:52 a.m. (2014-07-23 04:52:17 UTC) #5
Wladimir Palant
July 23, 2014, 6:20 a.m. (2014-07-23 06:20:32 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld